Skip to content

Fixes #17, #16 and #7 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2014
Merged

Fixes #17, #16 and #7 #18

merged 1 commit into from
Jul 30, 2014

Conversation

dantleech
Copy link
Member

  • Fixed links from implementation page
  • Added link to JCR2 Grammer reference
  • Mentioned seitwerks for providing the logo in footer

- Fixed links from implementation page
- Added link to JCR2 Grammer reference
- Mentioned seitwerks for providing the logo in footer
@@ -25,44 +25,44 @@
<div class="content">
{{ content }}
</div>
<div class="footer">Thanks to all contributors and also to <a href="http://www.seitwerk.de">seitwerks.de</a> for creating the logo</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any better suggestions for the footer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one could link to the PHPCR contributors list .. then again this would then miss the contributors for the other repos. would be cool if there would be an organization contributors list. So for now its fine imho.

lsmith77 added a commit that referenced this pull request Jul 30, 2014
@lsmith77 lsmith77 merged commit 9881d9f into master Jul 30, 2014
@lsmith77 lsmith77 deleted the various branch July 30, 2014 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants