Add PHP 8 compatibility and move to github actions #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
alexander-schranz
force-pushed
the
feature/add-githubactions
branch
2 times, most recently
from
8617f49 to
047523c
Compare
dantleech
reviewed
Jan 16, 2021
| - 'master' | ||
| - '[0-9]+.x' | ||
| - '[0-9]+.[0-9]+' | ||
| - '[0-9]+.[0-9]+.x' |
There was a problem hiding this comment.
i'd say remove these, as we won't be supporting separate branches.
There was a problem hiding this comment.
done. and tests are all green now: https://github.com/alexander-schranz/phpcr-shell/pull/1/checks
alexander-schranz
force-pushed
the
feature/add-githubactions
branch
from
047523c to
c33b1b8
Compare
alexander-schranz
force-pushed
the
feature/add-githubactions
branch
from
c33b1b8 to
3e4aadc
Compare
|
Nice work :) I'll tag a new version |
|
Tagged 1.3.0 and updated the badge in the README 👍 |
|
@dantleech Thats great, Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See alexander-schranz#1