Query result formatter: remove column 'Index' from table head

[middlebrain]

There is no data column for the head column 'Index'.

[dbu]

are you sure that there never is? index would be for multivalue properties. have you tried with multivalue properties? if you did and saw nothing, then it might not have been implemented...

[middlebrain]

At the moment, the column Index exists on the table head only.

In the foreach loop there is no code, which collect data for this column:

phpcr-shell/src/PHPCR/Shell/Console/Helper/ResultFormatterHelper.php

Lines 69 to 78 in bc9b29f

	$table->setHeaders(array_merge([
	'Path',
	'Index',
	], $result->getColumnNames()));
	foreach ($result->getRows() as $row) {
	$values = array_merge([
	$row->getPath(),
	], $row->getValues());

The table header and the rest of the table are therefore out of sync.

Multivalue properties in the QueryResult are either empty or stringified (depending on the repository implementation).

[dbu]

thanks, then this makes sense.

should we tag a new release with these fixes? or is there more to come very soon? (we can always tag another version in a week or 2, there is no shortage of version numbers ;-) but if you intend to fix more stuff this week, or are aware of problems, we could delay the release a bit)

[middlebrain]

One fix is still on the way.