Skip to content

Enforce termination of queries #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2015
Merged

Enforce termination of queries #166

merged 1 commit into from
Jun 4, 2015

Conversation

dantleech
Copy link
Member

Enforce query termination, fixes: #162

Note that this does not allow multile lines, but it does at least prevent the execution of queries prematurely.

@dantleech dantleech force-pushed the enforce_query_termination branch from 4585921 to 6901c50 Compare June 4, 2015 10:49
dbu added a commit that referenced this pull request Jun 4, 2015
@dbu
Merge pull request #166 from phpcr/enforce_query_termination
6835681 
Enforce termination of queries
@dbu dbu merged commit 6835681 into master Jun 4, 2015
@lsmith77 lsmith77 removed the wip/poc label Jun 4, 2015
@dbu dbu deleted the enforce_query_termination branch June 4, 2015 14:52
@dbu
Copy link
Member

dbu commented Jun 4, 2015

cool, thanks!
multiline would be really helpful. and when the ; is enforced anyways, it should be easy to do, just wait until you see a ; before parsing the query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-executing queries is dangerous
3 participants
@dantleech @dbu @lsmith77