Add support for symfony 5 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/symfony-5-support
branch
from
fd27b3b to
3c73138
Compare
dantleech
reviewed
Nov 20, 2019
dbu
approved these changes
Nov 20, 2019
alexander-schranz
force-pushed
the
enhancement/symfony-5-support
branch
from
3c73138 to
f831bee
Compare
alexander-schranz
force-pushed
the
enhancement/symfony-5-support
branch
from
f831bee to
bfac996
Compare
|
hm, those errors look weird. is this a problem with mocking, or a bug in jackalope that we do not see inside jackalope itself? afaik this is stricter checking that php 7.4 is doing. (we could split symfony 5 and php 7.4 update - symfony 5 seems fine and could be merged) |
dbu
reviewed
Feb 12, 2020
alexander-schranz
force-pushed
the
enhancement/symfony-5-support
branch
3 times, most recently
from
a1d3187 to
9fc3602
Compare
|
@dbu requires: jackalope/jackalope#356 |
alexander-schranz
force-pushed
the
enhancement/symfony-5-support
branch
from
9fc3602 to
dc7e9ff
Compare
alexander-schranz
force-pushed
the
enhancement/symfony-5-support
branch
from
649c2b1 to
1f3b5b1
Compare
|
@dbu ready for review :) |
|
do you want a release? |
|
@dbu release would be great :) |
66 tasks
plozmun
pushed a commit
to plozmun/phpcr-migrations
that referenced
this pull request
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: jackalope/jackalope-fs#25, jackalope/jackalope-fs#26