add tests for mix:lastModified and handling for implementation loader #125
Conversation
| * | ||
| * We do not enforce the update for the workspace operations as that would | ||
| * invalidate the purpose of those methods and potentially lead to big | ||
| * performance penalties. |
There was a problem hiding this comment.
is this sane? with phpcr-odm for example, we never use the workspace operations anyways...
There was a problem hiding this comment.
i do not understand the comment
There was a problem hiding this comment.
there is Workspace::removeItem that does not go through a session. in jackrabbit for example, we simply send the path of what should be deleted to jackrabbit, without even loading that node. if we would require this to change the date, we would lose all performance gains of that as we would have to load the node first to change the modification date.
There was a problem hiding this comment.
hmm i think i still do not get it .. but I have no objections in the PR. if you want we can discuss it tomorrow at the office.
There was a problem hiding this comment.
i'll still make the comment more explicit, then merge.
add tests for mix:lastModified and handling for implementation loader
tests around the behaviour with mix:lastModified
this complements jackalope/jackalope#201 but should just lead to skipped tests if nothing is done