Use Path::isAbsolute to check absolute path

Author: dantleech

lib/Domain/FilePath.php

@@ -14,22 +14,22 @@ private function __construct(string $path)
         $this->path = $path;
     }
 
-    public function isAbsolute()
+    public function isAbsolute(): bool
     {
-        return 0 === strpos($this->path, '/');
+        return Path::isAbsolute($this->path);
     }
 
     public function __toString()
     {
         return $this->path;
     }
 
-    public static function fromString($path)
+    public static function fromString($path): FilePath
     {
         return new self($path);
     }
 
-    public static function fromParts(array $parts)
+    public static function fromParts(array $parts): FilePath
     {
         $path = implode('/', $parts);
 

tests/Unit/Domain/FilePathTest.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace Phpactor\ClassFileConverter\Tests\Unit\Domain;
+
+use PHPUnit\Framework\TestCase;
+use Phpactor\ClassFileConverter\Domain\FilePath;
+
+class FilePathTest extends TestCase
+{
+    /**
+     * @dataProvider provideIsAbsolute
+     */
+    public function testIsAbsolute(string $path, bool $expected)
+    {
+        $path = FilePath::fromString($path);
+        self::assertEquals($expected, $path->isAbsolute());
+    }
+
+    public function provideIsAbsolute()
+    {
+        yield 'not absolute unix' => [
+            'foobar/barfoo',
+            false,
+        ];
+
+        yield 'absolute unix' => [
+            '/foobar/barfoo',
+            true,
+        ];
+
+        yield 'absolute windows' => [
+            'c:\foobar\barfoo',
+            true,
+        ];
+
+        yield 'not absolute windows' => [
+            'foobar\barfoo',
+            false,
+        ];
+
+        yield 'absolute phar' => [
+            'phar:///barfoo',
+            true
+        ];
+
+        yield 'not absolute phar' => [
+            'phar://barfoo',
+            false,
+        ];
+    }
+}