ISSUE-345: snake to camel config

Author: tatevikg1

config/services/normalizers.yml

@@ -4,6 +4,14 @@ services:
     autoconfigure: true
     public: false
 
+  Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter: ~
+
+  Symfony\Component\Serializer\Normalizer\ObjectNormalizer:
+    arguments:
+      $classMetadataFactory: '@?serializer.mapping.class_metadata_factory'
+      $nameConverter: '@Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter'
+#      $propertyTypeExtractor: '@?serializer.property_type_extractor'
+
   PhpList\RestBundle\Serializer\SubscriberNormalizer:
     tags: [ 'serializer.normalizer' ]
     autowire: true

src/Entity/SubscriberRequest.php

@@ -15,8 +15,8 @@ class SubscriberRequest implements RequestInterface
     public string $email;
 
     #[Assert\Type(type: 'bool')]
-    public ?bool $request_confirmation = null;
+    public ?bool $requestConfirmation = null;
 
     #[Assert\Type(type: 'bool')]
-    public ?bool $html_email = null;
+    public ?bool $htmlEmail = null;
 }

src/Service/Manager/SubscriberManager.php

@@ -21,10 +21,10 @@ public function createSubscriber(SubscriberRequest $subscriberRequest): Subscrib
     {
         $subscriber = new Subscriber();
         $subscriber->setEmail($subscriberRequest->email);
-        $confirmed = (bool)$subscriberRequest->request_confirmation;
+        $confirmed = (bool)$subscriberRequest->requestConfirmation;
         $subscriber->setConfirmed(!$confirmed);
         $subscriber->setBlacklisted(false);
-        $subscriber->setHtmlEmail((bool)$subscriberRequest->html_email);
+        $subscriber->setHtmlEmail((bool)$subscriberRequest->htmlEmail);
         $subscriber->setDisabled(false);
 
         $this->subscriberRepository->save($subscriber);

src/Validator/RequestValidator.php

@@ -9,15 +9,15 @@
 use Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException;
 use Symfony\Component\Serializer\SerializerInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
-use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Throwable;
 
 class RequestValidator
 {
     public function __construct(
         private readonly SerializerInterface $serializer,
         private readonly ValidatorInterface $validator
-    ) {}
+    ) {
+    }
 
     public function validate(Request $request, string $dtoClass): RequestInterface
     {
@@ -33,7 +33,18 @@ public function validate(Request $request, string $dtoClass): RequestInterface
         $errors = $this->validator->validate($dto);
 
         if (count($errors) > 0) {
-            throw new UnprocessableEntityHttpException((string) $errors);
+            $lines = [];
+            foreach ($errors as $violation) {
+                $lines[] = sprintf(
+                    '%s: %s',
+                    $violation->getPropertyPath(),
+                    $violation->getMessage()
+                );
+            }
+
+            $message = implode("\n", $lines);
+
+            throw new UnprocessableEntityHttpException($message);
         }
 
         return $dto;

tests/Integration/Controller/SubscriberControllerTest.php

@@ -106,10 +106,10 @@ public static function invalidSubscriberDataProvider(): array
             'email is an empty string' => [['email' => '']],
             'email is invalid string' => [['email' => 'coffee and cigarettes']],
             'email as boolean' => [['email' => true]],
-            'html_email as integer' => [['email' => 'kate@example.com', 'html_email' => 1]],
-            'html_email as string' => [['email' => 'kate@example.com', 'html_email' => 'yes']],
-            'request_confirmation as string' => [['email' => 'kate@example.com', 'request_confirmation' => 'needed']],
-            'disabled as string' => [['email' => 'kate@example.com', 'request_confirmation' => 1]],
+            'html_email as integer' => [['email' => 'kate@example.com', 'htmlEmail' => 1]],
+            'html_email as string' => [['email' => 'kate@example.com', 'htmlEmail' => 'yes']],
+            'request_confirmation as string' => [['email' => 'kate@example.com', 'requestConfirmation' => 'needed']],
+            'disabled as string' => [['email' => 'kate@example.com', 'requestConfirmation' => 1]],
         ];
     }
 
@@ -129,9 +129,9 @@ public function testPostSubscribersWithValidSessionKeyAssignsProvidedSubscriberD
         $email = 'subscriber@example.com';
         $jsonData = [
             'email' => $email,
-            'request_confirmation' => true,
+            'requestConfirmation' => true,
             'blacklisted' => true,
-            'html_email' => true,
+            'htmlEmail' => true,
             'disabled' => true,
         ];