[FEATURE] Support Hyperlinks to local pages in rst and md #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
requested changes
Dec 12, 2023
packages/guides/src/ReferenceResolvers/PageHyperlinkResolver.php
Outdated
Show resolved
Hide resolved
linawolf
force-pushed
the
feature/link-to-page
branch
from
175dc68 to
66c69de
Compare
local pages can be linked by source name, target name or pure name without ending. Links can be relative to the current file or absolute to the project root
linawolf
force-pushed
the
feature/link-to-page
branch
from
2827f80 to
34007dd
Compare
linawolf
force-pushed
the
feature/link-to-page
branch
from
34007dd to
d5b281b
Compare
|
@jaapio please have another look |
jaapio
reviewed
Dec 12, 2023
packages/guides/src/ReferenceResolvers/PageHyperlinkResolver.php
Outdated
Show resolved
Hide resolved
local pages can be linked by source name, target name or pure name without ending. Links can be relative to the current file or absolute to the project root
jaapio
force-pushed
the
feature/link-to-page
branch
from
d5b281b to
44b079a
Compare
jaapio
approved these changes
Dec 12, 2023
|
please rebase this branch so we can merge this. Thanks a lot for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local pages can be linked by source name, target name or pure name without ending. Links can be relative to the current file or absolute to the project root