[FEATURE] Configure inventories via guides.xml #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All configuration can be done via guides.xml now
jaapio
approved these changes
Sep 9, 2023
wouterj
reviewed
Sep 12, 2023
| @@ -40,4 +40,15 @@ | |||
|
|
|||
| <xsd:attribute name="extends" type="xsd:string"/> | |||
| </xsd:complexType> | |||
|
|
|||
| <xsd:complexType name="inventories"> | |||
There was a problem hiding this comment.
This only defines the (complex) type named inventories but it doesn't use the type anywhere.
You need to also add <xsd:element name="inventories" type="inventories"> add the top of this document.
| @@ -39,6 +39,18 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->scalarNode('version')->end() | |||
| ->end() | |||
| ->end() | |||
| ->arrayNode('inventories') | |||
There was a problem hiding this comment.
You could also make this mode a prototyped array node. And add ->fixXmlConfig('inventory', 'inventories') (see the 4th example in https://symfony.com/doc/current/components/config/definition.html#array-nodes ).
This creates a config like
<guides>
<inventory>...</inventory>
<inventory>...</inventory>
</guides>And produces an array ['inventories' => ['...', '...']]
This is the common approach used by Symfony bundles when dealing with prototype nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.