[BUGFIX] Replace special signs in directive template names #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
force-pushed
the
bugfix/directives
branch
from
58f07a6 to
4ebc34a
Compare
linawolf
force-pushed
the
bugfix/directives
branch
2 times, most recently
from
a43ca71 to
1ed3f41
Compare
jaapio
reviewed
Aug 28, 2023
linawolf
force-pushed
the
bugfix/directives
branch
from
1ed3f41 to
8db4093
Compare
And handle directives in namespaces as having templates in subdirectories
linawolf
force-pushed
the
bugfix/directives
branch
from
8db4093 to
1d00d49
Compare
|
@jaapio I added tests, please have another look |
jaapio
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And handle directives in namespaces as having templates in subdirectories