Skip to content

Unindent code blocks automatically #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2023
Merged

Unindent code blocks automatically #442

merged 2 commits into from
Aug 25, 2023

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Jul 3, 2023

No description provided.

@greg0ire greg0ire mentioned this pull request Jul 3, 2023
Open
@greg0ire greg0ire force-pushed the auto-unindent branch 2 times, most recently from 03a7cf6 to b8ae00b Compare July 3, 2023 17:10
@jaapio
Copy link
Member

jaapio commented Jul 3, 2023

Nice @greg0ire this is much like I had it in my mind when I created the issue. Thanks for this improvement!

@greg0ire
Copy link
Contributor Author

greg0ire commented Jul 3, 2023

@jaapio note that it does not cover enumerated list and definition list, and I'm not sure it should… let me know if you want me to revert the list rule changes, because I'm not sure they are that beneficial 😛

@linawolf linawolf marked this pull request as ready for review August 21, 2023 18:20
@linawolf
Copy link
Contributor

linawolf commented Aug 21, 2023 •
edited
Loading

@jaapio I rebase @greg0ire PR and added some little bugfixes. Please let us review and merge this, I am willing to do further changes if greg0ire has no time for them

@linawolf linawolf requested a review from jaapio August 21, 2023 18:21
@linawolf
Copy link
Contributor

@greg0ire I think it is a great idea to leave out the list handling for now so we can get the rest merged. Could you take care of this for me?

@greg0ire
Copy link
Contributor Author

greg0ire commented Aug 25, 2023 •
edited
Loading

Sorry, long time not looking into this. Do you mean just restoring ListRule.php to its previous state?

@linawolf
Copy link
Contributor

linawolf commented Aug 25, 2023 via email

@jaapio jaapio merged commit 8d3c812 into phpDocumentor:main Aug 25, 2023
@greg0ire greg0ire deleted the auto-unindent branch August 25, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapio jaapio jaapio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @jaapio @linawolf