Skip to content

[BUGFIX] inline break needs to convert to space #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Oct 1, 2024

An inline break needs to be converted to a space as markdown doesn't care about linebreaks in a paragraph.

fixes #1091

@jaapio jaapio requested a review from linawolf October 1, 2024 20:44
@jaapio jaapio force-pushed the fix/inline-breaks branch 2 times, most recently from 8c8f9e7 to 345f19c Compare October 1, 2024 20:49
@linawolf
Copy link
Contributor

linawolf commented Oct 2, 2024

Please update the integration test baseline, there have already been errors in some places that we didnt notice. Update: Did that for you

jaapio and others added 2 commits October 2, 2024 07:52
An inline break needs to be converted to a space as markdown
doesn't care about linebreaks in a paragraph.
@linawolf linawolf merged commit ea0a4e4 into main Oct 2, 2024
41 checks passed
@linawolf linawolf deleted the fix/inline-breaks branch October 2, 2024 06:03
@phpdoc-bot
Copy link

💚 All backports created successfully

Status Branch Result
1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

1 similar comment
@phpdoc-bot
Copy link

💚 All backports created successfully

Status Branch Result
1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Single line breaks within a paragraph in MarkDown are remove instead of replaced by a space
3 participants