[FEATURE] Delegate URL Handling to UrlGenerators

Author: linawolf

packages/guides-restructured-text/resources/config/guides-restructured-text.php

@@ -4,6 +4,7 @@
 
 use phpDocumentor\Guides\Graphs\Directives\UmlDirective;
 use phpDocumentor\Guides\NodeRenderers\NodeRenderer;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolverInterface;
 use phpDocumentor\Guides\RestructuredText\Directives\AdmonitionDirective;
 use phpDocumentor\Guides\RestructuredText\Directives\AttentionDirective;
 use phpDocumentor\Guides\RestructuredText\Directives\BaseDirective;
@@ -106,7 +107,6 @@
 use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 use phpDocumentor\Guides\RestructuredText\Toc\GlobSearcher;
 use phpDocumentor\Guides\RestructuredText\Toc\ToctreeBuilder;
-use phpDocumentor\Guides\UrlGeneratorInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
@@ -166,7 +166,7 @@
         ])
         ->set(ContainerDirective::class)
         ->set(ContentsDirective::class)
-        ->arg('$urlGenerator', service(UrlGeneratorInterface::class))
+        ->arg('$documentNameResolver', service(DocumentNameResolverInterface::class))
         ->set(CsvTableDirective::class)
         ->arg('$productions', service('phpdoc.guides.parser.rst.body_elements'))
         ->set(DangerDirective::class)

packages/guides-restructured-text/src/RestructuredText/Directives/ContentsDirective.php

@@ -6,9 +6,9 @@
 
 use phpDocumentor\Guides\Nodes\Menu\ContentMenuNode;
 use phpDocumentor\Guides\Nodes\Node;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolverInterface;
 use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
-use phpDocumentor\Guides\UrlGeneratorInterface;
 
 /**
  * Standarad rst `contents` directive
@@ -17,8 +17,9 @@
  */
 class ContentsDirective extends BaseDirective
 {
-    public function __construct(private readonly UrlGeneratorInterface $urlGenerator)
-    {
+    public function __construct(
+        private readonly DocumentNameResolverInterface $documentNameResolver,
+    ) {
     }
 
     public function getName(): string
@@ -32,7 +33,7 @@ public function process(
         Directive $directive,
     ): Node|null {
         $options = $directive->getOptions();
-        $absoluteUrl = $this->urlGenerator->absoluteUrl(
+        $absoluteUrl = $this->documentNameResolver->absoluteUrl(
             $blockContext->getDocumentParserContext()->getContext()->getDirName(),
             $blockContext->getDocumentParserContext()->getContext()->getCurrentFileName(),
         );

packages/guides-restructured-text/src/RestructuredText/Directives/ImageDirective.php

@@ -6,9 +6,9 @@
 
 use phpDocumentor\Guides\Nodes\ImageNode;
 use phpDocumentor\Guides\Nodes\Node;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolverInterface;
 use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
-use phpDocumentor\Guides\UrlGeneratorInterface;
 
 use function dirname;
 
@@ -21,8 +21,9 @@
  */
 class ImageDirective extends BaseDirective
 {
-    public function __construct(private readonly UrlGeneratorInterface $urlGenerator)
-    {
+    public function __construct(
+        private readonly DocumentNameResolverInterface $documentNameResolver,
+    ) {
     }
 
     public function getName(): string
@@ -36,7 +37,7 @@ public function processNode(
         Directive $directive,
     ): Node {
         return new ImageNode(
-            $this->urlGenerator->absoluteUrl(
+            $this->documentNameResolver->absoluteUrl(
                 dirname($blockContext->getDocumentParserContext()->getContext()->getCurrentAbsolutePath()),
                 $directive->getData(),
             ),

packages/guides-restructured-text/src/RestructuredText/Toc/GlobSearcher.php

@@ -6,14 +6,15 @@
 
 use Flyfinder\Specification\Glob;
 use phpDocumentor\Guides\ParserContext;
-use phpDocumentor\Guides\UrlGeneratorInterface;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolverInterface;
 
 use function rtrim;
 
 class GlobSearcher
 {
-    public function __construct(private readonly UrlGeneratorInterface $urlGenerator)
-    {
+    public function __construct(
+        private readonly DocumentNameResolverInterface $documentNameResolver,
+    ) {
     }
 
     /** @return string[] */
@@ -25,7 +26,7 @@ public function globSearch(ParserContext $parserContext, string $globPattern): a
         );
         $allFiles = [];
         foreach ($files as $file) {
-            $allFiles[] = $this->urlGenerator->absoluteUrl($parserContext->getDirName(), $file['filename']);
+            $allFiles[] = $this->documentNameResolver->absoluteUrl($parserContext->getDirName(), $file['filename']);
         }
 
         return $allFiles;

packages/guides-restructured-text/tests/unit/Parser/Productions/RuleTestCase.php

@@ -9,13 +9,13 @@
 use phpDocumentor\Guides\Nodes\InlineCompoundNode;
 use phpDocumentor\Guides\Nodes\ProjectNode;
 use phpDocumentor\Guides\ParserContext;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolver;
 use phpDocumentor\Guides\RestructuredText\MarkupLanguageParser;
 use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\InlineParser;
 use phpDocumentor\Guides\RestructuredText\Parser\LinesIterator;
 use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
-use phpDocumentor\Guides\UrlGenerator;
 use PHPUnit\Framework\TestCase;
 
 abstract class RuleTestCase extends TestCase
@@ -41,7 +41,7 @@ protected function createContext(string $input): BlockContext
             'test',
             1,
             self::createStub(FilesystemInterface::class),
-            new UrlGenerator(),
+            new DocumentNameResolver(),
         );
         $documentParserContext = new DocumentParserContext(
             $parserContext,

packages/guides-restructured-text/tests/unit/Parser/Productions/SectionRuleTest.php

@@ -20,12 +20,12 @@
 use phpDocumentor\Guides\Nodes\SectionNode;
 use phpDocumentor\Guides\Nodes\TitleNode;
 use phpDocumentor\Guides\ParserContext;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolverInterface;
 use phpDocumentor\Guides\RestructuredText\MarkupLanguageParser;
 use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\InlineParser;
 use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
-use phpDocumentor\Guides\UrlGeneratorInterface;
 
 final class SectionRuleTest extends RuleTestCase
 {
@@ -196,7 +196,7 @@ private function getDocumentParserContext(string $content): BlockContext
             'test',
             1,
             self::createStub(FilesystemInterface::class),
-            self::createStub(UrlGeneratorInterface::class),
+            self::createStub(DocumentNameResolverInterface::class),
         );
 
         $documentParserContext = new DocumentParserContext(

packages/guides/resources/config/guides.php

@@ -27,6 +27,8 @@
 use phpDocumentor\Guides\ReferenceResolvers\AnchorReferenceResolver;
 use phpDocumentor\Guides\ReferenceResolvers\DelegatingReferenceResolver;
 use phpDocumentor\Guides\ReferenceResolvers\DocReferenceResolver;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolver;
+use phpDocumentor\Guides\ReferenceResolvers\DocumentNameResolverInterface;
 use phpDocumentor\Guides\ReferenceResolvers\EmailReferenceResolver;
 use phpDocumentor\Guides\ReferenceResolvers\ExternalReferenceResolver;
 use phpDocumentor\Guides\ReferenceResolvers\InternalReferenceResolver;
@@ -39,14 +41,17 @@
 use phpDocumentor\Guides\Renderer\IntersphinxRenderer;
 use phpDocumentor\Guides\Renderer\LatexRenderer;
 use phpDocumentor\Guides\Renderer\TypeRendererFactory;
+use phpDocumentor\Guides\Renderer\UrlGenerator\AbsoluteUrlGenerator;
+use phpDocumentor\Guides\Renderer\UrlGenerator\AbstractUrlGenerator;
+use phpDocumentor\Guides\Renderer\UrlGenerator\ConfigurableUrlGenerator;
+use phpDocumentor\Guides\Renderer\UrlGenerator\RelativeUrlGenerator;
+use phpDocumentor\Guides\Renderer\UrlGenerator\UrlGeneratorInterface;
 use phpDocumentor\Guides\Settings\SettingsManager;
 use phpDocumentor\Guides\TemplateRenderer;
 use phpDocumentor\Guides\Twig\AssetsExtension;
 use phpDocumentor\Guides\Twig\EnvironmentBuilder;
 use phpDocumentor\Guides\Twig\Theme\ThemeManager;
 use phpDocumentor\Guides\Twig\TwigTemplateRenderer;
-use phpDocumentor\Guides\UrlGenerator;
-use phpDocumentor\Guides\UrlGeneratorInterface;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\HttpClient\HttpClient;
@@ -93,7 +98,10 @@
             '%vendor_dir%/phpdocumentor/guides/src/NodeRenderers',
         )
 
-        ->set(UrlGeneratorInterface::class, UrlGenerator::class)
+        ->set(AbsoluteUrlGenerator::class)
+        ->set(RelativeUrlGenerator::class)
+        ->set(UrlGeneratorInterface::class, ConfigurableUrlGenerator::class)
+        ->set(DocumentNameResolverInterface::class, DocumentNameResolver::class)
 
         ->set(Parser::class)
         ->arg('$parserStrategies', tagged_iterator('phpdoc.guides.parser.markupLanguageParser'))
@@ -118,7 +126,7 @@
         ->set(HttpClientInterface::class)
         ->factory([HttpClient::class, 'create'])
 
-        ->set(UrlGenerator::class)
+        ->set(AbstractUrlGenerator::class)
 
         ->set(ExternalReferenceResolver::class)
 

packages/guides/resources/template/tex/inline/inline-node.tex.twig

@@ -0,0 +1,3 @@
+{%- for child in node.children -%}
+    {{- renderNode(child) -}}
+{%- endfor -%}

packages/guides/resources/template/tex/inline/plain-text.tex.twig

@@ -0,0 +1 @@
+{{- node.value -}}

packages/guides/resources/template/tex/structure/header-title.tex.twig

@@ -0,0 +1,6 @@
+{%- apply spaceless -%}
+{%- set headingLevel = node.level -%}
+\{% if headingLevel == 1 %}section{% elseif headingLevel == 2 %}subsection{% elseif headingLevel == 3 %}subsubsection{% elseif headingLevel == 4 %}paragraph{% elseif headingLevel == 5 %}subparagraph{% elseif headingLevel == 6 %}subparagraph{% endif %}{
+{{- renderNode(node.value) -}}
+}
+{%- endapply -%}