[BUGFIX] Allow hyperlinks to anchors

linawolf · jaapio · commit 9135a2169b00 · 2023-09-02T11:56:45.000+02:00
Sphinx also allows them
diff --git a/packages/guides/src/ReferenceResolvers/ExternalReferenceResolver.php b/packages/guides/src/ReferenceResolvers/ExternalReferenceResolver.php
@@ -9,6 +9,7 @@
 
 use function parse_url;
 use function preg_match;
+use function str_starts_with;
 
 use const PHP_URL_SCHEME;
 
@@ -27,6 +28,12 @@ class ExternalReferenceResolver implements ReferenceResolver
 
     public function resolve(LinkInlineNode $node, RenderContext $renderContext): bool
     {
+        if (str_starts_with($node->getTargetReference(), '#')) {
+            $node->setUrl($node->getTargetReference());
+
+            return true;
+        }
+
         $url = parse_url($node->getTargetReference(), PHP_URL_SCHEME);
         if ($url !== null && $url !== false && preg_match('/^' . self::SUPPORTED_SCHEMAS . '$/', $url)) {
             $node->setUrl($node->getTargetReference());
diff --git a/tests/Integration/tests/hyperlink-to-anchor/expected/index.html b/tests/Integration/tests/hyperlink-to-anchor/expected/index.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <title>Some file</title>
+
+</head>
+<body>
+    <div class="section" id="some-file">
+    <h1>Some file</h1>
+
+            
+
+<ul>
+    <li><a href="#">link to myself</a></li>
+
+    <li><a href="#abc">link to some anchor</a></li>
+
+</ul>
+
+    </div>
+
+</body>
+</html>
diff --git a/tests/Integration/tests/hyperlink-to-anchor/input/index.rst b/tests/Integration/tests/hyperlink-to-anchor/input/index.rst
@@ -0,0 +1,6 @@
+Some file
+=========
+
+*   `link to myself <#>`__
+
+*   `link to some anchor <#abc>`__
