[!!!][TASK] Make output an option instead of argument

This way it can be set indepenently from the input

Author: linawolf

.github/workflows/documentation.yml

@@ -35,4 +35,4 @@ jobs:
           dependency-versions: "highest"
 
       - name: "Run guides-cli"
-        run: "vendor/bin/guides -vvv --no-progress docs /tmp/test --fail-on-log"
+        run: 'vendor/bin/guides -vvv --no-progress docs --output='/tmp/test' --fail-on-log"

Makefile

@@ -44,7 +44,7 @@ test-integration: ## Runs integration tests with phpunit/phpunit
 
 .PHONY: test-docs
 test-docs: ## Generate projects docs without warnings
-	$(PHP_BIN) vendor/bin/guides -vvv --no-progress docs /tmp/test --fail-on-log
+	$(PHP_BIN) vendor/bin/guides -vvv --no-progress docs --output="/tmp/test" --fail-on-log
 
 .PHONY: cleanup
 cleanup: cleanup-tests cleanup-build cleanup-cache

packages/guides-cli/src/Command/Run.php

@@ -59,9 +59,10 @@ public function __construct(
             InputArgument::OPTIONAL,
             'Directory to read for files',
         );
-        $this->addArgument(
+        $this->addOption(
             'output',
-            InputArgument::OPTIONAL,
+            null,
+            InputOption::VALUE_REQUIRED,
             'Directory to read for files',
         );
 
@@ -125,8 +126,8 @@ private function getSettingsOverridenWithInput(InputInterface $input): ProjectSe
             $settings->setInput((string) $input->getArgument('input'));
         }
 
-        if ($input->getArgument('output')) {
-            $settings->setOutput((string) $input->getArgument('output'));
+        if ($input->getOption('output')) {
+            $settings->setOutput((string) $input->getOption('output'));
         }
 
         if ($input->getOption('input-file')) {

tests/Integration/IntegrationTest.php

@@ -65,7 +65,7 @@ public function testHtmlIntegration(
             $input = new ArrayInput(
                 [
                     'input' => $inputPath,
-                    'output' => $outputPath,
+                    '--output' => $outputPath,
                     '--log-path' => $outputPath . '/logs',
                 ],
                 $command->getDefinition(),