[TASK] Split Anchor link resolvers

depends on #717

Author: linawolf

packages/guides/resources/config/guides.php

@@ -19,6 +19,7 @@
 use phpDocumentor\Guides\NodeRenderers\Html\TableNodeRenderer;
 use phpDocumentor\Guides\NodeRenderers\OutputAwareDelegatingNodeRenderer;
 use phpDocumentor\Guides\Parser;
+use phpDocumentor\Guides\ReferenceResolvers\AnchorHyperlinkResolver;
 use phpDocumentor\Guides\ReferenceResolvers\AnchorReducer;
 use phpDocumentor\Guides\ReferenceResolvers\AnchorReferenceResolver;
 use phpDocumentor\Guides\ReferenceResolvers\DelegatingReferenceResolver;
@@ -121,6 +122,8 @@
 
         ->set(EmailReferenceResolver::class)
 
+        ->set(AnchorHyperlinkResolver::class)
+
         ->set(AnchorReferenceResolver::class)
 
         ->set(InternalReferenceResolver::class)

packages/guides/src/ReferenceResolvers/AnchorHyperlinkResolver.php

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+namespace phpDocumentor\Guides\ReferenceResolvers;
+
+use phpDocumentor\Guides\Nodes\Inline\HyperLinkNode;
+use phpDocumentor\Guides\Nodes\Inline\LinkInlineNode;
+use phpDocumentor\Guides\RenderContext;
+use phpDocumentor\Guides\Renderer\UrlGenerator\UrlGeneratorInterface;
+
+/**
+ * Resolves references with an anchor URL.
+ *
+ * A link is an anchor if it starts with a hashtag
+ */
+class AnchorHyperlinkResolver implements ReferenceResolver
+{
+    public final const PRIORITY = -100;
+
+    public function __construct(
+        private readonly AnchorReducer $anchorReducer,
+        private readonly UrlGeneratorInterface $urlGenerator,
+    ) {
+    }
+
+    public function resolve(LinkInlineNode $node, RenderContext $renderContext): bool
+    {
+        if (!$node instanceof HyperLinkNode) {
+            return false;
+        }
+
+        $reducedAnchor = $this->anchorReducer->reduceAnchor($node->getTargetReference());
+        $target = $renderContext->getProjectNode()->getInternalTarget($reducedAnchor);
+
+        if ($target === null) {
+            return false;
+        }
+
+        $node->setUrl($this->urlGenerator->generateCanonicalOutputUrl($renderContext, $target->getDocumentPath(), $target->getAnchor()));
+        if ($node->getValue() === '') {
+            $node->setValue($target->getTitle() ?? '');
+        }
+
+        return true;
+    }
+
+    public static function getPriority(): int
+    {
+        return self::PRIORITY;
+    }
+}

packages/guides/src/ReferenceResolvers/AnchorReferenceResolver.php

@@ -26,18 +26,14 @@ public function __construct(
 
     public function resolve(LinkInlineNode $node, RenderContext $renderContext): bool
     {
-        $reducedAnchor = $this->anchorReducer->reduceAnchor($node->getTargetReference());
-        if ($node instanceof ReferenceNode) {
-            if ($node->getInterlinkDomain() !== '') {
-                return false;
-            }
-
-            $target = $renderContext->getProjectNode()->getInternalTarget($reducedAnchor, $node->getLinkType());
-        } else {
-            // Todo: move this to a separate resolver?
-            $target = $renderContext->getProjectNode()->getInternalTarget($reducedAnchor);
+        if (!$node instanceof ReferenceNode) {
+            return false;
         }
 
+        $reducedAnchor = $this->anchorReducer->reduceAnchor($node->getTargetReference());
+
+        $target = $renderContext->getProjectNode()->getInternalTarget($reducedAnchor, $node->getLinkType());
+
         if ($target === null) {
             return false;
         }