Merge pull request #593 from phpDocumentor/bugfix/menu

[BUGFIX] Fix generated menu when progress bar is active

Author: linawolf

docs/include.rst.txt

@@ -1,14 +1,3 @@
-..  documentblock::
-    :identifier: mainmenu
-
-    ..  rubric:: My Header
-
-    ..  menu::
-        :menu: mainmenu
-
-        /*
-        /*/index
-
 ..  documentblock::
     :identifier: navbar
 

packages/guides-cli/src/Command/Run.php

@@ -173,6 +173,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->commandBus->handle(
                 new RenderCommand(
                     $format,
+                    $documents,
                     $progressBar === null ? $documents : $progressBar->iterate($documents),
                     $sourceFileSystem,
                     $destinationFileSystem,

packages/guides/src/Handlers/RenderCommand.php

@@ -10,10 +10,14 @@
 
 final class RenderCommand
 {
-    /** @param iterable<DocumentNode> $documents */
+    /**
+     * @param DocumentNode[] $documentArray
+     * @param iterable<DocumentNode> $documentIterator
+     */
     public function __construct(
         private readonly string $outputFormat,
-        private readonly iterable $documents,
+        private readonly array $documentArray,
+        private readonly iterable $documentIterator,
         private readonly FilesystemInterface $origin,
         private readonly FilesystemInterface $destination,
         private readonly ProjectNode $projectNode,
@@ -26,10 +30,16 @@ public function getOutputFormat(): string
         return $this->outputFormat;
     }
 
-    /** @return iterable<DocumentNode> */
-    public function getDocuments(): iterable
+    /** @return DocumentNode[] $documentArray */
+    public function getDocumentArray(): array
     {
-        return $this->documents;
+        return $this->documentArray;
+    }
+
+    /** @return iterable<DocumentNode> $documentIterator */
+    public function getDocumentIterator(): iterable
+    {
+        return $this->documentIterator;
     }
 
     public function getOrigin(): FilesystemInterface

packages/guides/src/Renderer/BaseTypeRenderer.php

@@ -19,13 +19,13 @@ public function __construct(
 
     public function render(RenderCommand $renderCommand): void
     {
-        foreach ($renderCommand->getDocuments() as $document) {
+        foreach ($renderCommand->getDocumentIterator() as $document) {
             $this->commandBus->handle(
                 new RenderDocumentCommand(
                     $document,
                     RenderContext::forDocument(
                         $document,
-                        (array) $renderCommand->getDocuments(),
+                        $renderCommand->getDocumentArray(),
                         $renderCommand->getOrigin(),
                         $renderCommand->getDestination(),
                         $renderCommand->getDestinationPath(),