Skip to content

Param: fix phpdoc with reference hint #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2020
Merged

Param: fix phpdoc with reference hint #253

merged 3 commits into from
Aug 22, 2020

Conversation

voku
Copy link
Contributor

@voku voku commented Aug 17, 2020 •
edited
Loading

fix issue #251

This change is Reviewable

@voku
Copy link
Contributor Author

voku commented Aug 21, 2020

@jaapio without this fix, I got many false-positive errors from Simple-PHP-Code-Parser when I for example try to check phpstorm-stubs

@jaapio
Copy link
Member

jaapio commented Aug 21, 2020

Thanks, I will come back to you soon

@jaapio
Copy link
Member

jaapio commented Aug 22, 2020

This looks good to me 👍
We might want to improve the growing if statement, but that's ok for now.

@jaapio jaapio merged commit 699b11e into phpDocumentor:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voku @jaapio