Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push master version as new tag #245

Closed
Glancu opened this issue Jul 17, 2020 · 3 comments
Closed

Push master version as new tag #245

Glancu opened this issue Jul 17, 2020 · 3 comments

Comments

@Glancu
Copy link

Glancu commented Jul 17, 2020 •
edited
Loading

I need master version with tag like 5.1.1. I need this for phpspec/prophecy#491
@GrahamCampbell
Copy link
Contributor

The next version will be 5.2.0, not 5.1.1, and I don't think it's quite ready yet?

@jaapio
Copy link
Member

jaapio commented Jul 17, 2020

Still need to address the warnings in the unittests. If anyone has time to fix those PR's are very welcome.

@jaapio
Copy link
Member

jaapio commented Jul 20, 2020

Tag has been created.
I was able to run the unittest local on php 8, but with some tricks. github actions refuses to run phpunit because of some issue that was already solved. And will be part of phpunit 9.3.

@jaapio jaapio closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaapio @GrahamCampbell @Glancu