Merge pull request #205 from remicollet/issue-74

don't rely on 'args' in trace, not available in 7.4

Author: jaapio

src/DocBlock/Tags/InvalidTag.php

@@ -102,16 +102,16 @@ static function (&$value) : void {
             };
 
         do {
-            $trace = array_map(
-                static function (array $call) use ($flatten) : array {
-                    $call['args'] = $call['args'] ?? [];
-
-                    array_walk_recursive($call['args'], $flatten);
-
-                    return $call;
-                },
-                $exception->getTrace()
-            );
+            $trace = $exception->getTrace();
+            if (isset($trace[0]['args'])) {
+                $trace = array_map(
+                    static function (array $call) use ($flatten) : array {
+                        array_walk_recursive($call['args'], $flatten);
+                        return $call;
+                    },
+                    $trace
+                );
+            }
             $traceProperty->setValue($exception, $trace);
             $exception = $exception->getPrevious();
         } while ($exception !== null);

tests/unit/DocBlock/Tags/InvalidTagTest.php

@@ -56,8 +56,11 @@ public function testCreationWithErrorContainingClosure() : void
             self::assertSame('name', $tag->getName());
             self::assertSame('@name Body', $tag->render());
             self::assertSame($parentException, $tag->getException());
-            self::assertStringStartsWith('(Closure at', $tag->getException()->getPrevious()->getTrace()[0]['args'][0]);
-            self::assertStringContainsString(__FILE__, $tag->getException()->getPrevious()->getTrace()[0]['args'][0]);
+            $trace = $tag->getException()->getPrevious()->getTrace();
+            if (isset($trace[0]['args'])) { // Not set by default on 7.4
+                self::assertStringStartsWith('(Closure at', $trace[0]['args'][0]);
+                self::assertStringContainsString(__FILE__, $trace[0]['args'][0]);
+            }
             self::assertEquals($parentException, unserialize(serialize($parentException)));
         }
     }
@@ -81,10 +84,13 @@ public function testCreationWithErrorContainingResource() : void
             self::assertSame('name', $tag->getName());
             self::assertSame('@name Body', $tag->render());
             self::assertSame($parentException, $tag->getException());
-            self::assertStringStartsWith(
-                'resource(stream)',
-                $tag->getException()->getPrevious()->getTrace()[0]['args'][0]
-            );
+            $trace = $tag->getException()->getPrevious()->getTrace();
+            if (isset($trace[0]['args'])) { // Not set by default on 7.4
+                self::assertStringStartsWith(
+                    'resource(stream)',
+                    $trace[0]['args'][0]
+                );
+            }
             self::assertEquals($parentException, unserialize(serialize($parentException)));
         }
     }