Enhancement: Enable and configure header_comment fixer
#671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
Jul 16, 2022
| */ | ||
|
|
||
| $header = <<<TXT | ||
| Any ideas? |
localheinz
force-pushed
the
feature/header-comment
branch
from
2061247 to
4e10ef6
Compare
localheinz
force-pushed
the
feature/header-comment
branch
from
046cc3e to
e1a1418
Compare
localheinz
commented
Jul 16, 2022
| @@ -1,15 +1,11 @@ | |||
| <?php | |||
| /* | |||
| Yes, we know this can be used to view the source for any file | |||
There was a problem hiding this comment.
Probably makes sense to keep these, but move them.
|
I don't like this and I prefer not to do this. I see no real value in this as it's just comments. They are not even phpdoc. I would remove those strange |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Blocked by #670.
This pull request
header_commentfixermake coding-standardsFollows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/comment/header_comment.rst.