Skip to content

Fix: Use file name, not path to file #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Conversation

localheinz
Copy link
Contributor

This pull request

  • uses the file name, not the path to .php-cs-fixer.php

Follows #559.

@cmb69
Copy link
Member

cmb69 commented Jul 16, 2022

I guess I would have written it this way, but now wonder if that is really better.

@localheinz
Copy link
Contributor Author

@cmb69

It does not work with using the full path - when configuring the finder, everything is relative to the directory (or directories) that is (or are) used in the in() call.

@cmb69
Copy link
Member

cmb69 commented Jul 17, 2022

Thanks for the explanation!

@cmb69 cmb69 merged commit 2a01e8d into php:master Jul 17, 2022
@localheinz localheinz deleted the fix/file branch July 17, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants