Enhancement: Enable indentation_type fixer
#622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/indentation-type
branch
2 times, most recently
from
7b5ee9f to
5c6fee1
Compare
cmb69
approved these changes
Jul 11, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you for the PR! Looks good to me.
I'm fine with using four spaces indent instead of tabs, and generally fine with transitioning to PSR-12 (which is likely one of the most common coding standards for PHP OSS projects).
Contributor
Author
|
I believe that the specifics of a coding standard do not matter as long as they can be enforced automatically! |
Member
Right! I should have added: ", so we hopefully all can agree on using PSR-12". I wouldn't want to discuss any single rule individually, but rather get this mess somewhat cleaned up. :) |
Contributor
Author
localheinz
force-pushed
the
feature/indentation-type
branch
3 times, most recently
from
9739bef to
b0ddb28
Compare
localheinz
force-pushed
the
feature/indentation-type
branch
from
d9aebea to
252401c
Compare
Contributor
Author
|
Rebased! |
Contributor
Author
|
Thank you, @cmb69! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
indentation_typefixermake coding-standardsFollows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/whitespace/indentation_type.rst.