Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable indentation_type fixer #622

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 8, 2022

This pull request

  • enables the indentation_type fixer
  • runs make coding-standards

Follows #559.

πŸ’β€β™‚οΈ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/whitespace/indentation_type.rst.

@localheinz localheinz force-pushed the feature/indentation-type branch 2 times, most recently from 7b5ee9f to 5c6fee1 Compare July 11, 2022 17:21
@localheinz localheinz marked this pull request as ready for review July 11, 2022 17:23
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Looks good to me.

I'm fine with using four spaces indent instead of tabs, and generally fine with transitioning to PSR-12 (which is likely one of the most common coding standards for PHP OSS projects).

@localheinz
Copy link
Contributor Author

@cmb69

I believe that the specifics of a coding standard do not matter as long as they can be enforced automatically!

@cmb69
Copy link
Member

cmb69 commented Jul 11, 2022

I believe that the specifics of a coding standard do not matter as long as they can be enforced automatically!

Right! I should have added: ", so we hopefully all can agree on using PSR-12". I wouldn't want to discuss any single rule individually, but rather get this mess somewhat cleaned up. :)

@localheinz
Copy link
Contributor Author

@cmb69

As an alternative to enabling fixers individually, I have opened #638!

@localheinz localheinz force-pushed the feature/indentation-type branch 3 times, most recently from 9739bef to b0ddb28 Compare July 11, 2022 18:14
@localheinz localheinz force-pushed the feature/indentation-type branch from d9aebea to 252401c Compare July 11, 2022 18:18
@localheinz
Copy link
Contributor Author

@cmb69

Rebased!

@cmb69 cmb69 merged commit f3585d9 into php:master Jul 11, 2022
@localheinz localheinz deleted the feature/indentation-type branch July 11, 2022 19:48
@localheinz
Copy link
Contributor Author

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants