-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add "N" and "o" format specifiers to idate() #7586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build fails |
Travis failed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your efforts @xPaw
PS: This is my first review on PHP-SRC repo :)
Could you reply to #7586 (comment) to say how I should proceed here so this PR doesn't sit forever. |
Thank you! This looks good to me. @derickr, any objections? |
@derickr mind giving this another look? |
I have merged this into master now, and I have also updated the documentation: php/doc-en@5e865c8 |
Moved
timelib_isoweek_from_date
into case where it's actually needed. And changed the timestamp in tests so day of week difference is clear.With these formatters, it should cover all the ones
date
has (except for the ones that return a string, obviously)