Skip to content

Add "N" and "o" format specifiers to idate() #7586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add "N" and "o" format specifiers to idate() #7586

wants to merge 1 commit into from

Conversation

xPaw
Copy link
Contributor

@xPaw xPaw commented Oct 17, 2021

Moved timelib_isoweek_from_date into case where it's actually needed. And changed the timestamp in tests so day of week difference is clear.

With these formatters, it should cover all the ones date has (except for the ones that return a string, obviously)

@vaske
Copy link

vaske commented Oct 19, 2021

build fails

@xPaw
Copy link
Contributor Author

xPaw commented Oct 19, 2021

Travis failed on apt-get install failed, it's not an issue with the PR itself.

Copy link

@umutphp umutphp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your efforts @xPaw

PS: This is my first review on PHP-SRC repo :)

@xPaw xPaw requested a review from derickr October 25, 2021 18:47
@xPaw
Copy link
Contributor Author

xPaw commented Dec 29, 2021

Could you reply to #7586 (comment) to say how I should proceed here so this PR doesn't sit forever.

@cmb69
Copy link
Member

cmb69 commented Dec 29, 2021

Thank you! This looks good to me. @derickr, any objections?

@xPaw
Copy link
Contributor Author

xPaw commented May 12, 2022

@derickr mind giving this another look?

@derickr derickr self-assigned this May 12, 2022
derickr added a commit that referenced this pull request May 13, 2022
@derickr
Copy link
Member

derickr commented May 13, 2022

I have merged this into master now, and I have also updated the documentation: php/doc-en@5e865c8

@derickr derickr closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants