Skip to content

Update Zend Engine license and doc headers referencing it #7358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

weierophinney
Copy link

This patch accomplishes the following:

  • Updates the Zend/LICENSE file to the 2.01 version of the license. This primarily updates the legal entity owning the license, as Zend is now a subsidiary of Perforce.
  • Updates the copyright headers that refer to the Zend Engine license to update the owner and URLs referenced.

See #7166 for the conversation thread leading to this change.

Updated to:

- Reference 2.01 of the Zend Engine license, which updates the legal entity owning the license.
- Reference a URL to the 2.01 version of the license
- Provide the 2.01 version of the license in the LICENSE file

(See php#7166 for the discussion that prompted this patch.)
| that is bundled with this package in the file LICENSE, and is |
| available through the world-wide-web at the following url: |
| http://www.zend.com/license/2_00.txt. |
| https://www.zend.com/sites/zend/files/pdfs/zend-engine-license-2.01.txt |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "nice" boxes need to be extended.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to keep the patch minimal. Would like to hear from the release managers on this; @ramsey - what are your opinions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we could remove /pdfs/ from the URL given that the served file is not a PDF.

Could Zend devops move this file to https://www.zend.com/sites/zend/files/zend-engine-license-2.01.txt instead? Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no. :-/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the file to zend-license-2.01.txt?

Copy link
Contributor

@salathe salathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the "The PHP License, version 3.01" (in the LICENSE at the top level of this repo, and at https://www.php.net/license/3_01.txt) needs to be amended (possibly under a new version)? The PHP License, currently, states: PHP includes the Zend Engine, freely available at <http://www.zend.com>.

@krakjoe
Copy link
Member

krakjoe commented Aug 10, 2021

This doesn't really feel fair. It's reasonable that perforce bought the rights to the Zend engine as it was when the deal was done, but effectively claiming ownership of any new contributions does not seem ordinary, or fair. I don't remember agreeing to it, and I don't remember anyone being given the opportunity to agree either.

At this point - to be clear, the point where the entity Zend has absolutely nothing to do with PHP development - php-src needs to be licensed under one license, and it doesn't belong to perforce, or Zend.

@ramsey
Copy link
Member

ramsey commented Aug 11, 2021

php-src needs to be licensed under one license, and it doesn't belong to perforce, or Zend.

I don't disagree with this, but copyright is a really tricky subject. Technically, every contributor owns the copyrights for the portions they've contributed, and we do not require anyone to assign their copyright to any other entity—not Zend, not the PHP Group. But it's generally understood that the contributors have granted rights to the project under the same terms as the project's license (even if there's no CLA to show that agreement). So, changing the license could be problematic.

I'm going to reach out to a lawyer friend of mine who specializes in copyright law and is knowledgable about open source licensing. I want to show him this PR to see what he thinks.

In particular, I'm concerned about the fact that some of the PHP source code is licensed under the OSI-approved PHP License 3.01, while other parts of the source code are licensed under the Zend Engine License, which is not OSI-approved. It's nearly the same license as the PHP License, but since it's not listed on the OSI's website, this might be a cause for concern. However, I doubt many people are even aware of this oddity.

I'd love to see us transition everything under the same license, so I'll see what it would take to make that leap and if we'd even be able to do it.

@weierophinney
Copy link
Author

Does this mean that the "The PHP License, version 3.01" (in the LICENSE at the top level of this repo, and at https://www.php.net/license/3_01.txt) needs to be amended (possibly under a new version)? The PHP License, currently, states: PHP includes the Zend Engine, freely available at <http://www.zend.com>.

No, this can stay the way it is, though, technically, the Zend Engine is freely available here in the source code; that's where we'll point people if they come to Zend. 😄

Thanks for the feedback on the license text - will get that updated today.

@weierophinney
Copy link
Author

With regards to what prompted this: in the original issue (#7166), when I reviewed, I realized that a number of URLs were invalid, and that the legal entity listed had changed hands; each could have an impact on the validity of the license, and I wanted to ensure that end users had no ambiguity around that aspect. The Perforce legal team made the following changes:

  • Updated the legal entity in the header of the license (Zend went from being an LLC to an incorporated business, and is now a subsidiary of another; end users should know who that entity is now).
  • Updated the URLs for obtaining the source code of the Zend Engine. Previously, these pointed to www.zend.com - now they point here.

Those are the material changes. Neither Zend nor Perforce is asserting any other rights than it had previously; this is just an update to ensure the information in the license remains accurate.

(Also, regarding the statement "At this point - to be clear, the point where the entity Zend has absolutely nothing to do with PHP development": Dmitry is still employed by Zend to work on PHP!)

- Replace non-breaking spaces with normal spaces.
- Replace tags with spaces.
- Replace smartquotes with ASCII quotes.
- Remove trailing "." in URLs.
- Fix spacing issues due to reformatting.
@weierophinney
Copy link
Author

And also, FTR, I'd love to see a single license for the entirety of the PHP project; I was only doing due diligence here with the status quo.

@krakjoe
Copy link
Member

krakjoe commented Aug 11, 2021 via email

@ramsey
Copy link
Member

ramsey commented Aug 11, 2021

How do we move from here to the place we all want to be?

I have reached out to a lawyer to discuss this and will report back.

@salathe
Copy link
Contributor

salathe commented Aug 26, 2021

I have reached out to a lawyer to discuss this and will report back.

@ramsey Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants