Promote warning to ValueError for Spoofchecker::setRestrictionLevel() #6197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Sep 23, 2020
| @@ -143,8 +143,8 @@ PHP_METHOD(Spoofchecker, setRestrictionLevel) | |||
| USPOOF_MODERATELY_RESTRICTIVE != level && | |||
| USPOOF_MINIMALLY_RESTRICTIVE != level && | |||
| USPOOF_UNRESTRICTIVE != level) { | |||
| php_error_docref(NULL, E_WARNING, "Invalid restriction level value"); | |||
| return; | |||
| zend_argument_value_error(1, "must be one of the Spoofchecker::*_RESTRICTIVE constants or Spoofchecker::UNRESTRICTIVE"); | |||
There was a problem hiding this comment.
Seems tricky :) In this case, you could just list them all, 4 items don't seem too many for me. If the list gets too long, then just write "is invalid". Problem solved! :D
Girgias
force-pushed
the
intl-spoofchecker-warning-to-error
branch
from
9e4d357 to
dafb18b
Compare
nikic
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kocsismate is this error message fine? Or do you have a better idea on how to integrate the Spoofchecker::UNRESTRICTIVE constant with the other 4?