Fix UNKNOWN default values in ext/standard #6026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
standard-default
branch
2 times, most recently
from
4fc13d3 to
7845f73
Compare
kocsismate
force-pushed
the
standard-default
branch
2 times, most recently
from
b4071d0 to
2369e9c
Compare
nikic
reviewed
Sep 7, 2020
ext/standard/mt_rand.c
Outdated
|
|
||
| if (max_is_null) { | ||
| max = PHP_MT_RAND_MAX; | ||
| } |
There was a problem hiding this comment.
IMHO we should not touch mt_rand. The behavior implemented here is very unusual in that mt_rand($n) will now return mt_rand($n, mt_getrandmax()). It is a lot more typical for single-argument rand functions to interpret the argument as the upper bound, not the lower bound.
There was a problem hiding this comment.
Oh, after rethinking it, it is very unusual indeed. I'll revert it.
kocsismate
force-pushed
the
standard-default
branch
from
2369e9c to
f1e7caf
Compare
nikic
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.