Drop support for libreadline #3823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice: if merged, I plan to add a deprecation warning in 7.4 |
|
Looks like you'll have to install libedit on Travis. I'm personally fine with making this change. Supporting two different libraries with subtly different behavior and different feature set is not a good idea. If libedit is available everywhere, I don't see a disadvantage to normalizing on it. |
remicollet
force-pushed
the
issue-nolibreadline
branch
2 times, most recently
from
c64922b to
256d4c4
Compare
|
|
remicollet
force-pushed
the
issue-nolibreadline
branch
from
256d4c4 to
3dff2c0
Compare
libreadline is GPL, so incompatible with PHP
remicollet
force-pushed
the
issue-nolibreadline
branch
from
3dff2c0 to
5256d35
Compare
|
Rebased and travis is happy :) |
|
@remicollet What is the status of this removal? |
|
@remicollet do you want this still to be merged and can you rebase on current master? |
|
@remicollet this looks like it ought to be taken care of, the rebase looks non-trivial and I don't want to mess it up .... Hopefully we can get this sorted for 8.1, I'll add a milestone so that eyes are on it ... |
|
Differred, as need to be rebased... |
petk
added a commit
to petk/php-src
that referenced
this pull request
Jan 19, 2024
Readline library is not compatible with PHP license-wise and shouldn't be compiled into the executable. This can be simplified by using the libedit library with pkgconf determining its availability. This is a continuation of php#3823 and other discussions in the past.
|
Continuing this one here: #13184 |
petk
added a commit
to petk/php-src
that referenced
this pull request
Sep 13, 2024
This removes the GNU Readline library integration and relies on the libedit library if present. Issue is that there are several ext/readline libraries and GNU Readline license (GNU GPL 3) is not compatible with the PHP license. There was a similar attempt to fix this (phpGH-3823) and now fix continues here. Changes: - `--with-libedit` configure option removed (only `--with-readline` stays) This also fixes the phpdbg readline integration on *nix systems (using libedit library) for history (up/down keys and similar nice features).
petk
added a commit
to petk/php-src
that referenced
this pull request
Sep 14, 2024
This removes the GNU Readline library integration and relies on the libedit library if present. Issue is that there are several ext/readline libraries and GNU Readline license (GNU GPL 3) is not compatible with the PHP license. There was a similar attempt to fix this (phpGH-3823) and now fix continues here. Changes: - `--with-libedit` configure option removed (only `--with-readline` stays) - readline extension tests fixed: those required by only readline library removed, added missing skip reasons, some functions are always available, etc. - New PHP_SETUP_EDIT Autoconf macro that finds libedit This also fixes the phpdbg readline integration on *nix systems (using libedit library) for history (up/down keys and similar nice features) to not produce compile errors: ./configure --enable-phpdbg-readline make undefined reference to 'readline' undefined reference to 'add_history'
petk
added a commit
to petk/php-src
that referenced
this pull request
Sep 14, 2024
This removes the GNU Readline library integration and relies on the libedit library if present. Issue is that there are several ext/readline libraries and GNU Readline license (GNU GPL 3) is not compatible with the PHP license. There was a similar attempt to fix this (phpGH-3823) and now fix continues here. Changes: - `--with-libedit` configure option removed (only `--with-readline` stays) - readline extension tests fixed: those required by only readline library removed, added missing skip reasons, some functions are always available, etc. - New PHP_SETUP_EDIT Autoconf macro that finds libedit This also fixes the phpdbg readline integration on *nix systems (using libedit library) for history (up/down keys and similar nice features) to not produce compile errors: ./configure --enable-phpdbg-readline make undefined reference to 'readline' undefined reference to 'add_history'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libreadline is GPL, so incompatible with PHP
Notice: Windows already only support libedit