random: Fix memory leak when serialization fails#20383
Merged
ndossche merged 3 commits intophp:PHP-8.3from Nov 4, 2025
Merged
Conversation
TimWolla
reviewed
Nov 3, 2025
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
TimWolla
approved these changes
Nov 3, 2025
zeriyoshi
approved these changes
Nov 4, 2025
ndossche
added a commit
that referenced
this pull request
Nov 4, 2025
* PHP-8.3: random: Fix memory leak when serialization fails (#20383)
ndossche
added a commit
that referenced
this pull request
Nov 4, 2025
* PHP-8.4: random: Fix memory leak when serialization fails (#20383)
ndossche
added a commit
that referenced
this pull request
Nov 4, 2025
* PHP-8.5: random: Fix memory leak when serialization fails (#20383)
iliaal
added a commit
to iliaal/php-src
that referenced
this pull request
Apr 12, 2026
…e serialize callback fails Mt19937::__debugInfo() allocates a temporary HashTable with array_init(&t), then calls the engine's serialize callback, then inserts t into the return value. When the callback returns false, the method throws and returns via RETURN_THROWS() before t is inserted anywhere, so the HashTable leaks. PcgOneseq128XslRr64 and Xoshiro256StarStar alias the same method and share the leak. Same pattern as the __serialize() leak fixed in phpGH-20383 (720e006); __debugInfo() was missed in that cleanup. Apply the same reordering: insert t into return_value first, then let the callback populate it. On RETURN_THROWS() the return value is unwound cleanly. The path is latent in stock PHP because the three built-in serialize callbacks (mt19937, pcg, xoshiro) all return true, so no user code reaches the leak today. Fixing for symmetry with phpGH-20383 and to keep the pattern from regressing if a future engine grows a failing serialize path. Closes phpGH-21730
iliaal
added a commit
to iliaal/php-src
that referenced
this pull request
Apr 12, 2026
…e serialize callback fails Mt19937::__debugInfo() allocates a temporary HashTable with array_init(&t), calls the engine's serialize callback, and then inserts t into the return value. If the callback returns false, the method throws and hits RETURN_THROWS() before inserting t, so the HashTable leaks. PcgOneseq128XslRr64 and Xoshiro256StarStar alias the same method and share the leak. Niels Dossche fixed the same pattern in __serialize() via phpGH-20383 (720e006). That cleanup didn't touch __debugInfo(). Apply the same reordering here: insert t into return_value first, then let the callback populate it. RETURN_THROWS() then unwinds the return value cleanly. The path is latent in stock PHP because the three built-in serialize callbacks (mt19937, pcg, xoshiro) all return true, so no user code reaches the leak today. I'm fixing it for symmetry with phpGH-20383 and to keep the pattern from regressing if a future engine grows a failing serialize path. Closes phpGH-21730
iliaal
added a commit
to iliaal/php-src
that referenced
this pull request
Apr 12, 2026
…e serialize callback fails Mt19937::__debugInfo() allocates a temporary HashTable with array_init(&t), calls the engine's serialize callback, and then inserts t into the return value. If the callback returns false, the method throws and hits RETURN_THROWS() before inserting t, so the HashTable leaks. PcgOneseq128XslRr64 and Xoshiro256StarStar alias the same method and share the leak. Niels Dossche fixed the same pattern in __serialize() via phpGH-20383 (720e006). That cleanup didn't touch __debugInfo(). Apply the same reordering here: insert t into return_value first, then let the callback populate it. RETURN_THROWS() then unwinds the return value cleanly. The path is latent in stock PHP because the three built-in serialize callbacks (mt19937, pcg, xoshiro) all return true, so no user code reaches the leak today. I'm fixing it for symmetry with phpGH-20383 and to keep the pattern from regressing if a future engine grows a failing serialize path. Closes phpGH-21730
TimWolla
pushed a commit
that referenced
this pull request
Apr 12, 2026
…erialize callback fails (#21733) Mt19937::__debugInfo() allocates a temporary HashTable with array_init(&t), calls the engine's serialize callback, and then inserts t into the return value. If the callback returns false, the method throws and hits RETURN_THROWS() before inserting t, so the HashTable leaks. PcgOneseq128XslRr64 and Xoshiro256StarStar alias the same method and share the leak. Niels Dossche fixed the same pattern in __serialize() via GH-20383 (720e006). That cleanup didn't touch __debugInfo(). Apply the same reordering here: insert t into return_value first, then let the callback populate it. RETURN_THROWS() then unwinds the return value cleanly. The path is latent in stock PHP because the three built-in serialize callbacks (mt19937, pcg, xoshiro) all return true, so no user code reaches the leak today. I'm fixing it for symmetry with GH-20383 and to keep the pattern from regressing if a future engine grows a failing serialize path. Closes GH-21730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.