Deprecate returning non-string values from a user output handler #18932
+474
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Jun 24, 2025
And update tests
Girgias
reviewed
Jun 27, 2025
Girgias
reviewed
Jul 2, 2025
| int handler_count = php_output_get_level(); | ||
| if (handler_count) { | ||
| php_output_handler **handlers = (php_output_handler **) zend_stack_base(&OG(handlers)); | ||
| for (int iii = 0; iii < handler_count; ++iii) { |
There was a problem hiding this comment.
Could we have a better variable name than iii?
| /* user handler may have returned TRUE */ | ||
| status = PHP_OUTPUT_HANDLER_NO_DATA; | ||
| if (Z_TYPE(retval) != IS_FALSE && Z_TYPE(retval) != IS_TRUE) { | ||
| convert_to_string(&retval); |
There was a problem hiding this comment.
This may fail with non-stringable objects, also I would prefer zend_try_get_string() rather than converting the ZVAL.
There was a problem hiding this comment.
This part is unchanged from the original, I'd rather not change things
There was a problem hiding this comment.
OK, but can you add a test with a non-stringable object being returned from an output handler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecations_php_8_4