Replace @deprecated with #[\Deprecated] for internal constants
#18780
+641
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only covers constants declared via stub files, others will be handled separately in a later commit. Does not include the intl extension, since that had some errors relating to the cpp code; that extension will be updated separately. Also fix an undefined variable warning in gen_stub.php.
DanielEScherzer
force-pushed
the
constants-stubs-use-deprecated
branch
from
550eb12 to
2792802
Compare
DanielEScherzer
requested review from
kocsismate,
bukka,
nielsdos,
TimWolla,
zeriyoshi,
devnexen,
kamil-tekiela,
derickr and
adoy
as code owners
|
If you look at the filter arginfo you can see that the same strings are allocated twice. Do you think you can avoid this at least within the same arginfo file? |
TimWolla
reviewed
Jun 6, 2025
| * @cvalue MT_RAND_PHP | ||
| */ | ||
| #[\Deprecated(since: '8.3', message: 'as it uses a problematic version of Mt19937')] |
There was a problem hiding this comment.
Suggested change
| #[\Deprecated(since: '8.3', message: 'as it uses a problematic version of Mt19937')] | |
| #[\Deprecated(since: '8.3', message: 'as it uses a biased non-standard variant of Mt19937')] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only covers constants declared via stub files, others will be handled separately in a later commit.
Does not include the intl extension, since that had some errors relating to the cpp code; that extension will be updated separately.
Also fix an undefined variable warning in gen_stub.php.