Add ext/uri skeleton along with uriparser#18658
Conversation
TimWolla
left a comment
There was a problem hiding this comment.
Did not verify whether the uriparser files match the upstream sources.
| zend_class_entry *uri_exception_ce; | ||
| zend_class_entry *invalid_uri_exception_ce; | ||
| zend_class_entry *whatwg_invalid_url_exception_ce; |
There was a problem hiding this comment.
These are not currently exported, but exporting the exception CEs might make sense. I suggest to rename them to avoid conflicts.
The following pattern is used by ext/random:
| zend_class_entry *uri_exception_ce; | |
| zend_class_entry *invalid_uri_exception_ce; | |
| zend_class_entry *whatwg_invalid_url_exception_ce; | |
| zend_class_entry *uri_ce_Uri_UriException; | |
| zend_class_entry *uri_ce_Uri_InvalidUriException; | |
| zend_class_entry *uri_ce_Uri_WhatWg_InvalidUrlException; |
see
Lines 58 to 72 in c7db07e
There was a problem hiding this comment.
Let's make renames a bit later when the actual content is also added - at least I can then use the IDE to also rename the references. 🤔
|
@TimWolla I just validated that uriparser matches upstream at commit 019af45951c76415bd7d999313faf5c0e53aea0d |
|
I'll sign off for today so I'll check tomorrow again (after CI is green) |
|
Ah, I've just realized that I have to add back the UriConfig.h that was a manually added file IIRC, because the CMake based build script would have to generate it by default. |
TimWolla
left a comment
There was a problem hiding this comment.
LGTM.
Verified the uriparser sources against uriparser/uriparser@019af45 with the addition of the UriConfig.h.
|
After the merge, the ability to build PHP in a directory different from the source dir is broken. Please fix this ASAP. cc: @iluuu1994 @nielsdos |
Relates to #14461 and https://wiki.php.net/rfc/url_parsing_api