-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Create separate lexbor extension #18538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
c2b1e8d
to
6a309fe
Compare
9e9cb4c
to
c228b4a
Compare
In preparation of php#14461 (https://wiki.php.net/rfc/url_parsing_api)
c228b4a
to
accf126
Compare
Co-authored-by: Gina Peter Banyard <girgias@php.net>
@cmb69 for Windows maybe? |
I haven't actually checked that (can do later if necessary), but I think we need to install the actual lexbor headers; cf. Line 12 in 4122daa
I think that also needs to be done for POSIX systems, so phpize builds can work. |
Definitely. Also, you need to keep the selectors-adapted directory in ext/dom. Due to technical reasons this is a port of the upstream sources adapted to libxml2, so it has a dependency on libxml. |
I tried to follow what ext/dom did when it used to have the lexbor sources: https://github.com/php/php-src/blob/master/ext/dom/config.w32#L19 it didn't install the lexbor headers, other than putting them on the include path. Nevertheless, I'm trying out the suggestion.
Did I move it accidentally? 🤔 I tried to keep it in place, because I noticed that it was a PHP specific adaptation :) |
1f92120
to
054161b
Compare
@@ -26,5 +26,5 @@ if (PHP_LEXBOR == "yes") { | |||
|
|||
AC_DEFINE("HAVE_LEXBOR", 1, "Define to 1 if the PHP extension 'lexbor' is available."); | |||
|
|||
PHP_INSTALL_HEADERS("ext/lexbor", "php_lexbor.h"); | |||
PHP_INSTALL_HEADERS("ext/lexbor", "php_lexbor.h /"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows is still broken, based on the pcre one that cmb linked, perhaps it must be this?
PHP_INSTALL_HEADERS("ext/lexbor", "php_lexbor.h lexbor/");
Ah sorry I saw it was moved but didn't properly check it is indeed still in dom, thanks! |
In preparation of #14461 (https://wiki.php.net/rfc/url_parsing_api)
Windows support is pretty much TBD, as I have no way to test it.