Skip to content

ext/session refactoring: INI settings #16419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

ext/session refactoring: INI settings #16419

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b60e2f7
Convert some Session globals from char* to zend_string*
Girgias Aug 12, 2022
7c04d83
Convert session_name from char to zend_string
Girgias Aug 12, 2022
b1c18ae
Use NUL spelling
Girgias Aug 19, 2022
3b213dd
address review comments
Girgias Aug 19, 2022
b03b233
Check for session name criterias consistently
Girgias Aug 19, 2022
b01aa3e
Use new API for checking if string has NUL bytes
Girgias Aug 22, 2022
aaa67ee
Use known length
Girgias Aug 30, 2022
0393e65
Rebase alignments
jorgsowa Oct 13, 2024
6660a1c
Improved error messages
jorgsowa Dec 6, 2024
d5de6ed
Replaced invalid OnUpdateString
jorgsowa Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use known length
  • Loading branch information
@Girgias @jorgsowa
Girgias authored and jorgsowa committed Jan 10, 2025
commit aaa67ee90e3e2bafd1451c21639dccd6bf6bef07
6 changes: 3 additions & 3 deletions ext/session/session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2007,13 +2007,13 @@ PHP_FUNCTION(session_get_cookie_params)
add_assoc_long(return_value, "lifetime", PS(cookie_lifetime));
// TODO Use add_assoc_str() but figure out why it emits a
// Zend/zend_types.h:1222: zend_gc_delref: Assertion `(zval_gc_flags((p)->u.type_info) & ((1<<7)|(1<<8))) != (1<<7)' failed.
add_assoc_string(return_value, "path", ZSTR_VAL(PS(cookie_path)));
add_assoc_string(return_value, "domain", ZSTR_VAL(PS(cookie_domain)));
add_assoc_stringl(return_value, "path", ZSTR_VAL(PS(cookie_path)), ZSTR_LEN(PS(cookie_path)));
add_assoc_stringl(return_value, "domain", ZSTR_VAL(PS(cookie_domain)), ZSTR_LEN(PS(cookie_domain)));
add_assoc_bool(return_value, "secure", PS(cookie_secure));
add_assoc_bool(return_value, "httponly", PS(cookie_httponly));
// TODO Use add_assoc_str() but figure out why it emits a
// Zend/zend_types.h:1222: zend_gc_delref: Assertion `(zval_gc_flags((p)->u.type_info) & ((1<<7)|(1<<8))) != (1<<7)' failed.
add_assoc_string(return_value, "samesite", ZSTR_VAL(PS(cookie_samesite)));
add_assoc_stringl(return_value, "samesite", ZSTR_VAL(PS(cookie_samesite)), ZSTR_LEN(PS(cookie_samesite)));
}
/* }}} */

Expand Down