sapi/apache2: apache env with walk_to_top going to the parent request. #14953
Conversation
| if (zend_parse_parameters_none() == FAILURE) { | ||
| RETURN_THROWS(); | ||
| } | ||
| ZEND_PARSE_PARAMETERS_NONE(); |
There was a problem hiding this comment.
I'd prefer if the ZPP changes are committed in a separate commit than the rest.
up to now, we walked down the oldest request we can find, now if the current request is a subrequest, we just reach to its parent directly. Previous workflow for setting env affects a possible non main request within those internal redirections.
|
@cmb69 do you know apache well enough ? |
|
I have been looking through the Apache source and not sure if this is not going to result in some behaviour change. What is being done currently is to iterate through Btw. I could see that the What is actually the issue that you are trying to fix. Is there some specific problem that you are aware of? I would like to also try to do some integration using my new tool for FPM testing which is quite generic and I could potentially use it for this. It's getting to the working state so once I have few FPM tests working I could try to look on setting that up for mod_php. Then I should be able to test this properly. |
up to now, we walked down the oldest request we can find, now if the current request is a subrequest, we just reach to its parent directly.
Previous workflow for setting env affects a possible non main request within those internal redirections.