Pcntl getcpu sol #14188
Closed
Pcntl getcpu sol #14188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Build System
Category: Engine
Extension: pcntl
labels
petk
reviewed
May 9, 2024
ext/pcntl/config.m4
Outdated
Comment on lines
10
to
11
| AC_CHECK_FUNCS([getpriority setpriority wait3 wait4 sigwaitinfo sigtimedwait unshare rfork forkx pidfd_open]) | ||
| AC_CHECK_FUNCS([sched_setaffinity pthread_set_qos_class_self_np getcpuid]) |
There was a problem hiding this comment.
Suggested change
| AC_CHECK_FUNCS([getpriority setpriority wait3 wait4 sigwaitinfo sigtimedwait unshare rfork forkx pidfd_open]) | |
| AC_CHECK_FUNCS([sched_setaffinity pthread_set_qos_class_self_np getcpuid]) | |
| AC_CHECK_FUNCS(m4_normalize([ | |
| getpriority | |
| setpriority | |
| wait3 | |
| wait4 | |
| sigwaitinfo | |
| sigtimedwait | |
| unshare | |
| rfork | |
| forkx | |
| pidfd_open | |
| sched_setaffinity | |
| pthread_set_qos_class_self_np | |
| getcpuid | |
| ])) |
The m4_normalize can be used to simplify this a bit. And also these can be sorted alphabetically.
AC_CHECK_FUNCS(m4_normalize([
forkx
getcpuid
getpriority
pidfd_open
pthread_set_qos_class_self_np
rfork
sched_setaffinity
setpriority
sigtimedwait
sigwaitinfo
unshare
wait3
wait4
]))
using getcpuid having similar signature too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.