Skip to content

fiber fix wrong asm directives on (default) solaris build mode. #13320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Feb 3, 2024

Illumos/Solaris while being 64 bits produces by default 32 bits build. In this case building the i386 assembly.

Illumos/Solaris while being 64 bits produces by default 32 bits build.
In this case building the i386 assembly.
@devnexen devnexen requested a review from iluuu1994 as a code owner February 3, 2024 21:21
@devnexen
Copy link
Member Author

devnexen commented Feb 3, 2024

either @nielsdos or @iluuu1994 :) might be something to upstream too afterwards.

@devnexen
Copy link
Member Author

devnexen commented Feb 4, 2024

Merged already here.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a system to test on, but the code looks fine and if upstream also said it was fine, then fine by me too.
Thx.

@devnexen devnexen closed this in f9a83a4 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants