Fix GH-11104: STDIN/STDOUT/STDERR is not available for CLI without a script #11169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a script I found no reason why this is done this way. Of course this will allow users to do stupid stuff like `fclose(STDOUT);` etc. but if they type in that code they clearly know what they're doing...
iluuu1994
approved these changes
May 3, 2023
|
Why did this commit made the performance of many workloads much worse? |
|
@kocsismate this one didn't. See 4ca8daf#comments |
|
This causes a regression in PHPUnit (sebastianbergmann/phpunit#5356). |
sebastianbergmann
added a commit
to sebastianbergmann/phpunit
that referenced
this pull request
Sep 16, 2023
…s to communicate their result to the parent process As of PHP 8.3, specifically as of php/php-src#11169, it is no longer possible to capture direct writes to standard output. Such direct writes to standard output interfere with the previous approach where the child process would print its result to standard output from where the parent process would read it. Co-authored-by: Sebastian Bergmann <sb@sebastian-bergmann.de> Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found no reason why this is done this way.
Of course this will allow users to do stupid stuff like
fclose(STDOUT);etc. but if they type in that code they clearly know what they're doing...Easy fix, but I targeted master since this behaviour is long-standing and I'm not even sure this qualifies as a bug or as a feature.
Requesting review from Ilija since he also interacted with the issue.