Add CLEAN section to some IO tests #10081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdowad
reviewed
Dec 10, 2022
alexdowad
reviewed
Dec 10, 2022
|
This is a very good idea. Just added questions above on a couple of points which aren't clear to me. |
|
Looks good to me. |
cmb69
approved these changes
Dec 12, 2022
Those were already existing inconsistencies :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is far from all tests as plenty more in this folder are missing them.
But I saw that some of them didn't have it while working on something related and decided to try to add some sections (maybe should open an issue that is a good starting place to contribute).