Few tests failed building with new libxml 2.11.0

[andypost]

Description

The following tests fail:with https://gitlab.gnome.org/GNOME/libxml2/-/tags/v2.11.0#deprecations

Test DOMDocument::loadXML() detects not-well formed XML [ext/dom/tests/DOMDocument_loadXML_error2.phpt]
Test DOMDocument::load() detects not-well formed XML [ext/dom/tests/DOMDocument_load_error2.phpt]
Bug #61367: open_basedir bypass in libxml RSHUTDOWN: read test [ext/libxml/tests/bug61367-read_2.phpt]
libxml_disable_entity_loader() [ext/libxml/tests/libxml_disable_entity_loader_2.phpt]
Bug #26614 (CDATA sections skipped on line count) [ext/xml/tests/bug26614_libxml.phpt]

Diffs in first comment

PHP Version

PHP 8.1.18

Operating System

Alpinelinux

[andypost]

Diff is

TEST 5588/15656 [ext/dom/tests/DOMDocument_loadXML_error2.phpt]
========DIFF========
     Warning: DOMDocument::load%r(XML){0,1}%r(): AttValue: " or ' expected %s
     
�[1;32m003+ Warning: DOMDocument::loadXML(): internal error: xmlParseStartTag: problem parsing attributes in Entity, line: 4 in /builds/alpine/aports/community/php81/src/php-8.1.19RC1/ext/dom/tests/DOMDocument_loadXML_error2.php on line 7�[0m
�[1;31m003- Warning: DOMDocument::load%r(XML){0,1}%r(): attributes construct error %s�[0m
     
     Warning: DOMDocument::load%r(XML){0,1}%r(): Couldn't find end of Start Tag book %s
     
--
========DONE========
...
TEST 5599/15656 [ext/dom/tests/DOMDocument_load_error2.phpt]
========DIFF========
     Warning: DOMDocument::load%r(XML){0,1}%r(): AttValue: " or ' expected %s
     
�[1;32m003+ Warning: DOMDocument::load(): internal error: xmlParseStartTag: problem parsing attributes in /builds/alpine/aports/community/php81/src/php-8.1.19RC1/ext/dom/tests/not_well_formed2.xml, line: 4 in /builds/alpine/aports/community/php81/src/php-8.1.19RC1/ext/dom/tests/DOMDocument_load_error2.php on line 8�[0m
�[1;31m003- Warning: DOMDocument::load%r(XML){0,1}%r(): attributes construct error %s�[0m
     
     Warning: DOMDocument::load%r(XML){0,1}%r(): Couldn't find end of Start Tag book %s
     
--
========DONE========
...
TEST 7451/15656 [ext/libxml/tests/bug61367-read_2.phpt]
========DIFF========
--
     int(4)
     bool(true)
     
�[1;31m006- Warning: DOMDocument::loadXML(): I/O warning : failed to load external entity "file:///%s/test_bug_61367-read/bad" in %s on line %d�[0m
�[1;31m007- �[0m
     Warning: Attempt to read property "nodeValue" on null in %s on line %d
========DONE========
...
TEST 7459/15656 [ext/libxml/tests/libxml_disable_entity_loader_2.phpt]
========DIFF========
--
     
     Deprecated: Function libxml_disable_entity_loader() is deprecated in %s on line %d
     bool(false)
�[1;31m005- �[0m
�[1;31m006- Warning: DOMDocument::loadXML(): I/O warning : failed to load external entity "%s" in %s on line %d�[0m
     bool(true)
     Done
========DONE========
...
TEST 14990/15655 [ext/xml/tests/bug26614_libxml.phpt]
========DIFF========
�[1;32m002+ <DATA> at line 2, col 6 (byte 50)�[0m
     <DATA> at line 2, col %d (byte 9)
�[1;32m003+ </DATA> at line 9, col 8 (byte 96)�[0m
�[1;31m002- <DATA> at line 2, col %d (byte 9)�[0m
�[1;31m003- </DATA> at line 9, col %d (byte 55)�[0m
�[1;32m005+ <DATA> at line 2, col 6 (byte 50)�[0m
     <DATA> at line 2, col %d (byte 9)
�[1;32m006+ </DATA> at line 9, col 8 (byte 96)�[0m
�[1;31m005- <DATA> at line 2, col %d (byte 9)�[0m
�[1;31m006- </DATA> at line 9, col %d (byte 55)�[0m
     Text
�[1;32m008+ <DATA> at line 2, col 6 (byte 50)�[0m
�[1;32m009+ </DATA> at line 9, col 8 (byte 96)�[0m
�[1;31m008- <DATA> at line 2, col %d (byte 9)�[0m
�[1;31m009- </DATA> at line 9, col %d (byte 55)�[0m
========DONE========

[nielsdos]

The tests whose message differs can be fixed by duplicating the test: have a version for <2.11 and a version for >=2.11
Some other tests have a missing warning, php_libxml_ctx_error_level is actually called but the parser->input pointer is NULL, which means that PHP will not print the warning. I'll try to figure out why the input pointer is NULL.

EDIT: it seems that the actual problem is the error_type being 2 instead of 0 ?

[andypost]

Thank you! meantime this tests are excluded and the rest going good alpinelinux/aports@2b8cddf and alpinelinux/aports@482b784

[nielsdos]

I just performed a bisect on libxml2 and found this commit: https://gitlab.gnome.org/GNOME/libxml2/-/commit/9a82b94a94bd310db426edd453b0f38c6c8f69f5 is the first commit that breaks the PHP behaviour wrt the parser->input state.

[andypost]

As I got lots of old parser-related APIs are deprecated, that's why mentioned in description