Fixed GH-18247: dba_popen() memory leak on invalid path.

and a handful more error code paths.

Author: devnexen

ext/dba/dba.c

@@ -865,6 +865,9 @@ static void php_dba_open(INTERNAL_FUNCTION_PARAMETERS, bool persistent)
 		if (!connection->info->lock.fp) {
 			/* stream operation already wrote an error message */
 			efree(resource_key);
+			zend_string_release_ex(connection->hash, persistent);
+			dba_close_info(connection->info);
+			connection->info = NULL;
 			zval_ptr_dtor(return_value);
 			RETURN_FALSE;
 		}
@@ -886,6 +889,9 @@ static void php_dba_open(INTERNAL_FUNCTION_PARAMETERS, bool persistent)
 		if (!connection->info->fp) {
 			/* stream operation already wrote an error message */
 			efree(resource_key);
+			zend_string_release_ex(connection->hash, persistent);
+			dba_close_info(connection->info);
+			connection->info = NULL;
 			zval_ptr_dtor(return_value);
 			RETURN_FALSE;
 		}
@@ -896,6 +902,9 @@ static void php_dba_open(INTERNAL_FUNCTION_PARAMETERS, bool persistent)
 			if (SUCCESS != php_stream_cast(connection->info->fp, PHP_STREAM_AS_FD, (void*)&connection->info->fd, 1)) {
 				php_error_docref(NULL, E_WARNING, "Could not cast stream");
 				efree(resource_key);
+				zend_string_release_ex(connection->hash, persistent);
+				dba_close_info(connection->info);
+				connection->info = NULL;
 				zval_ptr_dtor(return_value);
 				RETURN_FALSE;
 #ifdef F_SETFL
@@ -932,6 +941,9 @@ static void php_dba_open(INTERNAL_FUNCTION_PARAMETERS, bool persistent)
 			}
 		}
 		efree(resource_key);
+		zend_string_release_ex(connection->hash, persistent);
+		dba_close_info(connection->info);
+		connection->info = NULL;
 		zval_ptr_dtor(return_value);
 		RETURN_FALSE;
 	}
@@ -942,6 +954,7 @@ static void php_dba_open(INTERNAL_FUNCTION_PARAMETERS, bool persistent)
 		if (zend_register_persistent_resource(resource_key, resource_key_len, connection->info, le_pdb) == NULL) {
 			php_error_docref(NULL, E_WARNING, "Could not register persistent resource");
 			efree(resource_key);
+			dba_close_connection(connection);
 			zval_ptr_dtor(return_value);
 			RETURN_FALSE;
 		}