[RFC] New attribute #[NotSerializable]

Author: MaxSem

Zend/tests/attributes/033_not_serializable.phpt

@@ -0,0 +1,23 @@
+--TEST--
+#[NotSerializable]
+--FILE--
+<?php
+
+#[NotSerializable]
+class C {}
+
+try {
+    serialize(new C());
+} catch (Throwable $ex) {
+    echo $ex->getMessage() . "\n";
+}
+
+try {
+    var_dump(unserialize('O:1:"C":0:{}'));
+} catch (Throwable $ex) {
+    echo $ex->getMessage() . "\n";
+}
+
+--EXPECTF--
+Serialization of 'C' is not allowed
+Unserialization of 'C' is not allowed

Zend/zend_attributes.c

@@ -30,6 +30,7 @@ ZEND_API zend_class_entry *zend_ce_allow_dynamic_properties;
 ZEND_API zend_class_entry *zend_ce_sensitive_parameter;
 ZEND_API zend_class_entry *zend_ce_sensitive_parameter_value;
 ZEND_API zend_class_entry *zend_ce_override;
+ZEND_API zend_class_entry *zend_ce_not_serializable;
 
 static zend_object_handlers attributes_object_handlers_sensitive_parameter_value;
 
@@ -80,6 +81,19 @@ static void validate_allow_dynamic_properties(
 	scope->ce_flags |= ZEND_ACC_ALLOW_DYNAMIC_PROPERTIES;
 }
 
+static void validate_not_serializable(
+		zend_attribute *attr, uint32_t target, zend_class_entry *scope)
+{
+	if (scope->ce_flags & ZEND_ACC_TRAIT) {
+		zend_error_noreturn(E_ERROR, "Cannot apply #[NotSerializable] to trait");
+	}
+	if (scope->ce_flags & ZEND_ACC_INTERFACE) {
+		zend_error_noreturn(E_ERROR, "Cannot apply #[NotSerializable] to interface");
+	}
+
+	scope->ce_flags |= ZEND_ACC_NOT_SERIALIZABLE;
+}
+
 ZEND_METHOD(Attribute, __construct)
 {
 	zend_long flags = ZEND_ATTRIBUTE_TARGET_ALL;
@@ -132,6 +146,11 @@ ZEND_METHOD(SensitiveParameterValue, __debugInfo)
 	RETURN_EMPTY_ARRAY();
 }
 
+ZEND_METHOD(NotSerializable, __construct)
+{
+	ZEND_PARSE_PARAMETERS_NONE();
+}
+
 static HashTable *attributes_sensitive_parameter_value_get_properties_for(zend_object *zobj, zend_prop_purpose purpose)
 {
 	return NULL;
@@ -380,6 +399,10 @@ void zend_register_attribute_ce(void)
 
 	zend_ce_override = register_class_Override();
 	zend_mark_internal_attribute(zend_ce_override);
+
+	zend_ce_not_serializable = register_class_NotSerializable();
+	attr = zend_mark_internal_attribute(zend_ce_not_serializable);
+	attr->validator = validate_not_serializable;
 }
 
 void zend_attributes_shutdown(void)

Zend/zend_attributes.h

@@ -44,6 +44,7 @@ extern ZEND_API zend_class_entry *zend_ce_allow_dynamic_properties;
 extern ZEND_API zend_class_entry *zend_ce_sensitive_parameter;
 extern ZEND_API zend_class_entry *zend_ce_sensitive_parameter_value;
 extern ZEND_API zend_class_entry *zend_ce_override;
+extern ZEND_API zend_class_entry *zend_ce_not_serializable;
 
 typedef struct {
 	zend_string *name;

Zend/zend_attributes.stub.php

@@ -71,3 +71,12 @@ final class Override
 {
     public function __construct() {}
 }
+
+/**
+ * @strict-properties
+ */
+#[Attribute(Attribute::TARGET_CLASS)]
+final class NotSerializable
+{
+    public function __construct() {}
+}

Zend/zend_attributes_arginfo.h

@@ -3,7 +3,7 @@ References to objects for which Serializable::serialize() returned NULL should u
 --FILE--
 <?php
 
-class NotSerializable implements Serializable {
+class MyNotSerializable implements Serializable {
     public function serialize() {
         return null;
     }
@@ -12,7 +12,7 @@ class NotSerializable implements Serializable {
     }
 }
 
-$obj = new NotSerializable();
+$obj = new MyNotSerializable();
 $data = [$obj, $obj];
 var_dump($s = serialize($data));
 var_dump(unserialize($s));