changes from review

devnexen · devnexen · commit ac5dc7e38f69 · 2023-07-04T21:27:40.000+01:00
diff --git a/UPGRADING b/UPGRADING
@@ -205,6 +205,9 @@ PHP 8.3 UPGRADE NOTES
 6. New Functions
 ========================================
 
+- GD:
+  . Added imagerotated which copy a rotated area from a defined position and angle.
+
 - JSON:
   . Added json_validate(), which returns whether the json is valid for
     the given $depth and $options.
diff --git a/ext/gd/gd.c b/ext/gd/gd.c
@@ -1078,7 +1078,6 @@ PHP_FUNCTION(imagecopyrotated)
 	angle = A;
 
 	gdImageCopyRotated(im_dst, im_src, dstX, dstY, srcX, srcY, srcW, srcH, angle);
-	RETURN_TRUE;
 }
 #endif
 
diff --git a/ext/gd/gd.stub.php b/ext/gd/gd.stub.php
@@ -521,7 +521,7 @@ function imagecolorexactalpha(GdImage $image, int $red, int $green, int $blue, i
 function imagecopyresampled(GdImage $dst_image, GdImage $src_image, int $dst_x, int $dst_y, int $src_x, int $src_y, int $dst_width, int $dst_height, int $src_width, int $src_height): bool {}
 
 #ifdef HAVE_GD_COPY_ROTATED
-function imagecopyrotated(GdImage $dst_image, GdImage $src_image, float $dst_x, float $dst_y, int $src_x, int $src_y, int $src_width, int $src_height, int $angle): bool {}
+function imagecopyrotated(GdImage $dst_image, GdImage $src_image, float $dst_x, float $dst_y, int $src_x, int $src_y, int $src_width, int $src_height, int $angle): void {}
 #endif
 
 #ifdef PHP_WIN32
diff --git a/ext/gd/gd_arginfo.h b/ext/gd/gd_arginfo.h

Original file line number	Diff line number	Diff line change
`@@ -1078,7 +1078,6 @@ PHP_FUNCTION(imagecopyrotated)`
`1078`	`1078`	`angle = A;`
`1079`	`1079`
`1080`	`1080`	`gdImageCopyRotated(im_dst, im_src, dstX, dstY, srcX, srcY, srcW, srcH, angle);`
`1081`		`- RETURN_TRUE;`
`1082`	`1081`	`}`
`1083`	`1082`	`#endif`
`1084`	`1083`