Skip to content

Commit 57463cf

Browse files
cmb69cmb69
committed
Drop all JIT related XFAILS from phpdbg test suite
phpdbg now disables JIT, so these cause XFAIL warnings.
1 parent 32cd5a1 commit 57463cf

19 files changed

+0
-93
lines changed

‎sapi/phpdbg/tests/breakpoints_001.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Fundamental breakpoints functionality
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
b 3
115
r

‎sapi/phpdbg/tests/breakpoints_002.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Preserve breakpoints on restart
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
b breakpoints_002.php:4
115
r

‎sapi/phpdbg/tests/breakpoints_003.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Test deleting breakpoints
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
b 4
115
b del 0

‎sapi/phpdbg/tests/breakpoints_004.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Test opcode breakpoints
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
b ZEND_ECHO
115
r

‎sapi/phpdbg/tests/bug73927.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ Bug #73927 (phpdbg fails with windows error prompt at "watch array")
55
if (getenv('SKIP_ASAN')) {
66
die("skip intentionally causes segfaults");
77
}
8-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
9-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
10-
}
118
?>
129
--PHPDBG--
1310
b 19

‎sapi/phpdbg/tests/exceptions_003.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Test breaks on HANDLE_EXCEPTION
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
b 5
115
r

‎sapi/phpdbg/tests/finish_leave_001.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
test finish and leave commands
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--INI--
104
opcache.optimization_level=0
115
--PHPDBG--

‎sapi/phpdbg/tests/info_002.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
info constants test
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
b 10
115
r

‎sapi/phpdbg/tests/next_001.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Test next command on function boundaries
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
b 4
115
r

‎sapi/phpdbg/tests/phpdbg_break_next.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Test phpdbg_break_next() function
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
r
115
c

‎sapi/phpdbg/tests/phpdbg_get_executable_stream_wrapper.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Getting executable lines from custom wrappers
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
r
115
q

‎sapi/phpdbg/tests/run_002.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
Stdin and escaped args being passed to run command
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--CLEAN--
104
<?php
115
@unlink("run_002_tmp.fixture");

‎sapi/phpdbg/tests/set_exception_handler.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--TEST--
22
set_exception_handler() in phpdbg
3-
--SKIPIF--
4-
<?php
5-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
6-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
7-
}
8-
?>
93
--PHPDBG--
104
r
115
c

‎sapi/phpdbg/tests/watch_001.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ Test simple recursive watchpoint
55
if (PHP_INT_SIZE == 4) {
66
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
77
}
8-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
9-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
10-
}
118
if (getenv('SKIP_ASAN')) {
129
die("skip intentionally causes segfaults");
1310
}

‎sapi/phpdbg/tests/watch_002.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ Test simple array watchpoint with replace
55
if (PHP_INT_SIZE == 4) {
66
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
77
}
8-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
9-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
10-
}
118
if (getenv('SKIP_ASAN')) {
129
die("skip intentionally causes segfaults");
1310
}

‎sapi/phpdbg/tests/watch_003.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ Test simple watchpoint with replace
55
if (PHP_INT_SIZE == 4) {
66
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
77
}
8-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
9-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
10-
}
118
if (getenv('SKIP_ASAN')) {
129
die("skip intentionally causes segfaults");
1310
}

‎sapi/phpdbg/tests/watch_004.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ Test detection of inline string manipulations on zval watch
55
if (PHP_INT_SIZE == 4) {
66
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
77
}
8-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
9-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
10-
}
118
if (getenv('SKIP_ASAN')) {
129
die("skip intentionally causes segfaults");
1310
}

‎sapi/phpdbg/tests/watch_005.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ Test proper watch comparisons when having multiple levels of indirection from a
55
if (PHP_INT_SIZE == 4) {
66
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
77
}
8-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
9-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
10-
}
118
if (getenv('SKIP_ASAN')) {
129
die("skip intentionally causes segfaults");
1310
}

‎sapi/phpdbg/tests/watch_006.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ Test multiple watch elements pointing to the same watchpoint
55
if (PHP_INT_SIZE == 4) {
66
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
77
}
8-
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
9-
die('xfail breakpoint/watchpoint issues with JIT on Windows');
10-
}
118
if (getenv('SKIP_ASAN')) {
129
die("skip intentionally causes segfaults");
1310
}

0 commit comments

Comments
 (0)