We should free the memory of any curl_slist returned by curl_easy_getinfo

pierrick · pierrick · commit 42a91750dde3 · 2011-12-05T22:23:19.000Z
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@320466 c90b9560-bf6c-de11-be94-00142212c4b1
diff --git a/ext/curl/interface.c b/ext/curl/interface.c
@@ -3031,6 +3031,7 @@ PHP_FUNCTION(curl_getinfo)
 								add_next_index_string(return_value, slist->data, 1);
 								slist = slist->next;
 							}
+							curl_slist_free_all(slist);
 						} else {
 							RETURN_FALSE;
 						}

Original file line number	Diff line number	Diff line change
`@@ -3031,6 +3031,7 @@ PHP_FUNCTION(curl_getinfo)`
`3031`	`3031`	`add_next_index_string(return_value, slist->data, 1);`
`3032`	`3032`	`slist = slist->next;`
`3033`	`3033`	`}`
	`3034`	`+ curl_slist_free_all(slist);`
`3034`	`3035`	`} else {`
`3035`	`3036`	`RETURN_FALSE;`
`3036`	`3037`	`}`