Fix DOMCharacterData::replaceWith() with itself

Previously, when replacing the node with itself (or contained within
itself), the node disappeared.

Closes GH-11770.

Author: nielsdos

NEWS

@@ -10,6 +10,7 @@ PHP                                                                        NEWS
   . Fix DOMEntity field getter bugs. (nielsdos)
   . Fix incorrect attribute existence check in DOMElement::setAttributeNodeNS.
     (nielsdos)
+  . Fix DOMCharacterData::replaceWith() with itself. (nielsdos)
 
 - FFI:
   . Fix leaking definitions when using FFI::cdef()->new(...). (ilutov)

ext/dom/characterdata.c

@@ -410,8 +410,7 @@ PHP_METHOD(DOMCharacterData, replaceWith)
 	id = ZEND_THIS;
 	DOM_GET_OBJ(context, id, xmlNodePtr, intern);
 
-	dom_parent_node_after(intern, args, argc);
-	dom_child_node_remove(intern);
+	dom_child_replace_with(intern, args, argc);
 }
 
 #endif

ext/dom/tests/DOMCharacterData_replaceWith_self.phpt

@@ -0,0 +1,15 @@
+--TEST--
+DOMCharacterData::replaceWith() with itself
+--EXTENSIONS--
+dom
+--FILE--
+<?php
+$dom = new DOMDocument;
+$dom->loadXML('<?xml version="1.0"?><container><![CDATA[Hello]]></container>');
+$cdata = $dom->documentElement->firstChild;
+$cdata->replaceWith($cdata);
+echo $dom->saveXML();
+?>
+--EXPECT--
+<?xml version="1.0"?>
+<container><![CDATA[Hello]]></container>