Skip to content

Commit 0763d6b

Browse files
committed
use zend_string_equals_ci
1 parent 49bd049 commit 0763d6b

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

Zend/zend_compile.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3051,14 +3051,11 @@ ZEND_API void zend_initialize_class_data(zend_class_entry *ce, zend_bool nullify
30513051

30523052
uint32_t zend_get_class_fetch_type(zend_string *name) /* {{{ */
30533053
{
3054-
if (name->len == sizeof("self") - 1 &&
3055-
!strncasecmp(name->val, "self", sizeof("self") - 1)) {
3054+
if (zend_string_equals_literal_ci(name, "self")) {
30563055
return ZEND_FETCH_CLASS_SELF;
3057-
} else if (name->len == sizeof("parent") - 1 &&
3058-
!strncasecmp(name->val, "parent", sizeof("parent") - 1)) {
3056+
} else if (zend_string_equals_literal_ci(name, "parent")) {
30593057
return ZEND_FETCH_CLASS_PARENT;
3060-
} else if (name->len == sizeof("static") - 1 &&
3061-
!strncasecmp(name->val, "static", sizeof("static") - 1)) {
3058+
} else if (zend_string_equals_literal_ci(name, "static")) {
30623059
return ZEND_FETCH_CLASS_STATIC;
30633060
} else {
30643061
return ZEND_FETCH_CLASS_DEFAULT;
@@ -3253,10 +3250,6 @@ static inline zend_bool zend_string_equals_str_ci(zend_string *str1, zend_string
32533250
}
32543251
/* }}} */
32553252

3256-
#define zend_string_equals_literal_ci(str, c) \
3257-
((str)->len == sizeof(c) - 1 \
3258-
&& !zend_binary_strcasecmp((str)->val, (str)->len, (c), sizeof(c) - 1))
3259-
32603253
static void zend_adjust_for_fetch_type(zend_op *opline, uint32_t type) /* {{{ */
32613254
{
32623255
switch (type & BP_VAR_MASK) {

Zend/zend_string.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,9 @@ static zend_always_inline zend_bool zend_string_equals(zend_string *s1, zend_str
214214
return s1 == s2 || (s1->len == s2->len && !memcmp(s1->val, s2->val, s1->len));
215215
}
216216

217+
#define zend_string_equals_literal_ci(str, c) \
218+
((str)->len == sizeof(c) - 1 && !zend_binary_strcasecmp((str)->val, (str)->len, (c), sizeof(c) - 1))
219+
217220
#define zend_string_equals_literal(str, literal) \
218221
((str)->len == sizeof(literal)-1 && !memcmp((str)->val, literal, sizeof(literal) - 1))
219222

0 commit comments

Comments
 (0)