Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.4] XSLTProcessor::setParameterのエラー内容の翻訳 #208

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[PHP 8.4] XSLTProcessor::setParameterのエラー内容の翻訳 #208

merged 2 commits into from
Dec 11, 2024

Conversation

t2aking
Copy link
Contributor

@t2aking t2aking commented Dec 11, 2024

php/doc-en#4135 の変更を反映しました。

KentarouTakeda
KentarouTakeda approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

訳はLGTMです。EN-Revisionの取得元を修正させて頂きました。原文の「プルリクエスト内のコミット」から取得されたと思うのですが、正しくは「プルリクエストのマージコミット」になります。

コミットID取得元

こちらでマージします、ありがとうございました！

@KentarouTakeda KentarouTakeda merged commit 5ca9632 into php:master Dec 11, 2024
1 check passed
@KentarouTakeda KentarouTakeda mentioned this pull request Dec 11, 2024
Open
@t2aking
Copy link
Contributor Author

t2aking commented Dec 11, 2024

レビューありがとうございました！
EN-Revisionについて承知しました！

@t2aking t2aking deleted the xsl-84-setparameter-errors branch December 12, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KentarouTakeda KentarouTakeda KentarouTakeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t2aking @KentarouTakeda