Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] DOMNode::DOCUMENT_*定数とDOMNode::compareDocumentPositionに関する翻訳 #189

Merged
merged 7 commits into from
Nov 24, 2024

Conversation

jdkfx
Copy link
Contributor

@jdkfx jdkfx commented Nov 24, 2024

内容が似ているので、以下の2点を取り込み

@jdkfx jdkfx changed the title WIP: [PHP 8.4] DOMNode::DOCUMENT_*定数に関する翻訳 [PHP 8.4] DOMNode::DOCUMENT_*定数とDOMNode::compareDocumentPositionに関する翻訳 Nov 24, 2024
@jdkfx jdkfx marked this pull request as ready for review November 24, 2024 06:34
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!LGTMです。

後続の修正が楽になるよう、インデントや改行を原文と揃える調整だけ行わせていただきました。

@jdkfx
Copy link
Contributor Author

jdkfx commented Nov 24, 2024

@KentarouTakeda
GitHubのdiffからコピーした際に余計な空白や必要な改行が入っていなかったのかもしれません。
対応ありがとうございます!

@KentarouTakeda KentarouTakeda merged commit 2a392a8 into php:master Nov 24, 2024
1 check passed
@jdkfx jdkfx deleted the DOMNode-constants branch November 24, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants